Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong rank in Song Selection screen sometimes #33

Closed
ericpignet opened this issue Aug 11, 2020 · 0 comments · Fixed by #34
Closed

Wrong rank in Song Selection screen sometimes #33

ericpignet opened this issue Aug 11, 2020 · 0 comments · Fixed by #34
Labels

Comments

@ericpignet
Copy link
Collaborator

Sometimes the max rank for a song in the Song Selection screen is incorrect and does not correspond to the max skill.
Example:
image
image

I noticed a couple of issues in the code which sets the max rank used in the n進行描画() method:
File CActSelectステータスパネル.cs line 56:

  • it compares a rank: DTXMania.CScoreIni.tランク値を計算して返す(0, c曲リストノード.arスコア[j].譜面情報.最大スキル[i]) to a Skill value (95), which is not correct
  • if the condition is true, it assigns value DTXMania.CScoreIni.tランク値を計算して返す(0, cスコア.譜面情報.最大スキル[i]) as a max rank to display. But this is not correct, this value is the same regardless the difficulty level. The value to use is DTXMania.CScoreIni.tランク値を計算して返す(0, c曲リストノード.arスコア[j].譜面情報.最大スキル[i])

Fixing this line and always recalculating the rank from the song's skill value would also solve another issue, which is happening when the BestRank value from the score.ini file was wrongly set by a previous DTXMania version (original 3.62).
In CStage結果.cs the c曲リストノード.arスコア[j].譜面情報.最大ランク[i] value is only updated when this.b新記録ランク[i] is true, which is not happening when the BestRank value from score.ini file was incorrect. This is happening to me quite often as original 3.62 was ranking too high in the Results screen. So 3.62a doesn't detect it as a higher rank and the Song Selection screen is not updated.

ericpignet referenced this issue in ericpignet/DTXmaniaNX Aug 11, 2020
…is incorrect and does not correspond to the max skill.
limyz added a commit that referenced this issue Aug 11, 2020
Fix issue #33 where max rank for a song in the Song Selection screen …
@limyz limyz added the bug label Aug 11, 2020
@limyz limyz closed this as completed Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants