Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show private channel if no message was sent (and we did not selected this channel) #167

Closed
RomaricMourgues opened this issue Aug 25, 2020 · 0 comments
Closed

Do not show private channel if no message was sent (and we did not selected this channel) #167

RomaricMourgues opened this issue Aug 25, 2020 · 0 comments
Assignees
@RomaricMourgues
Labels
enhancement New feature or request javascript Pull requests that update Javascript code
Milestone
2020.Q3

Comments

@RomaricMourgues
Copy link
Contributor

Do not show private channel if no message was sent (and we did not selected this channel)

Why:

  • P1 want to start a discussion with P2
  • P1 miss click and start a discussion with P3
  • Both P3 and P1 will see the channel

We can solve this only in front using the "messages read cursor" vs "total messages cursor"
@RomaricMourgues RomaricMourgues added enhancement New feature or request javascript Pull requests that update Javascript code labels Aug 25, 2020
RomaricMourgues added a commit that referenced this issue Sep 1, 2020
@RomaricMourgues
🌟 Chat improvements
818378a 
* Add offline indicator and fix ws notif refresh

* Implement more mute options

* Update backend for new mute options

* Fix notifications not visible or too visible

* Fix messages list moving up / down when send

* Remove direct messages channel when empty

* Fix notifications and Twacode parser

Closes #197
Closes #198
Closes #203
Closes #166
Closes #167
Closes #161
Closes #169
@RomaricMourgues RomaricMourgues added this to the 2020.Q3 milestone Sep 7, 2020
@snyk-bot snyk-bot mentioned this issue Dec 31, 2022
Open
@snyk-bot snyk-bot mentioned this issue Jan 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomaricMourgues RomaricMourgues

Labels
enhancement New feature or request javascript Pull requests that update Javascript code
Projects
None yet
Milestone
2020.Q3
Development

No branches or pull requests
2 participants
@RomaricMourgues @stephanevieira75