Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a notice to warn users that the company has reached the maximum number of users it can invite #1901

Closed
Tracked by #1965
, #1980
...
RomaricMourgues opened this issue Jan 26, 2022 · 4 comments
Closed
Tracked by #1965
, #1980
...

Add a notice to warn users that the company has reached the maximum number of users it can invite #1901

RomaricMourgues opened this issue Jan 26, 2022 · 4 comments
Assignees
@RomaricMourgues
Labels
qa:failed

Comments

@RomaricMourgues
Copy link
Contributor

RomaricMourgues commented Jan 26, 2022 •
edited

In order to fix #1744

To do this, we must leverage the stats.members_count information in the company object + the plan.features.members limit also in the company object.

If the plan.features.members is undefined or <= 0 then it means there is no limitation and banner should not be shown.

In the mockups bellow you can see how it looks from the workspace users management page or if we directly try to open the "invite members" popup.

Screenshot 2022-01-26 at 15.35.53.png

Screenshot 2022-01-26 at 15.35.59.png
@RomaricMourgues
Copy link
Contributor Author

@BenoitTallandier do you validate this ?

@BenoitTallandier
Copy link
Contributor

Perfect,
Just for the link to the console in the popup, I think something like "Upgrade your plan" is more clear for the user :)

stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Feb 2, 2022
linagora#1901 Add a notice to warn users that the company has reached…
664346e 
… the maximum number of users it can invite
@stephanevieira75 stephanevieira75 mentioned this issue Feb 2, 2022
Merged
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Feb 2, 2022
linagora#1901 Update workspace-pending-users.spect.ts
41dc2a5
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Feb 2, 2022
linagora#1901 Update users.spec.ts
1268c72
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Feb 2, 2022
linagora#1901 Update users.spec.ts
8c18d54
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Feb 2, 2022
linagora#1901 Update should 200 when company exists in users.spec.ts
b7ad07f
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Feb 2, 2022
linagora#1901 Update should 200 when company exists in users.spec.ts
049b862
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Feb 2, 2022
linagora#1901 Update workspace-pending-users.spec.ts
3543251
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Feb 3, 2022
linagora#1901 Resolve threads
d20e22a
RomaricMourgues pushed a commit that referenced this issue Feb 7, 2022
@stephanevieira75
🛠 #1900 Workspace members invite fixes (#1911)
b404273 
* #1900 Verify that members can invite other users to the company/workspace (and not only the workspace moderators)

* #1901 Add a notice to warn users that the company has reached the maximum number of users it can invite

* #1901 Update workspace-pending-users.spect.ts

* #1901 Update users.spec.ts

* #1901 Update should 200 when company exists in users.spec.ts

* #1901 Update workspace-pending-users.spec.ts

* #1901 Resolve threads
RomaricMourgues pushed a commit that referenced this issue Feb 7, 2022
@stephanevieira75
🛠 #1900 Workspace members invite fixes (#1911)
6f894ec 
* #1900 Verify that members can invite other users to the company/workspace (and not only the workspace moderators)

* #1901 Add a notice to warn users that the company has reached the maximum number of users it can invite

* #1901 Update workspace-pending-users.spect.ts

* #1901 Update users.spec.ts

* #1901 Update should 200 when company exists in users.spec.ts

* #1901 Update workspace-pending-users.spec.ts

* #1901 Resolve threads
@hantt12
Copy link

hantt12 commented Feb 17, 2022

As I can see there is no warning message and user is still able to add users after maximum number is reached

Peek 2022-02-17 15-57.gif

RomaricMourgues added a commit to RomaricMourgues/Twake that referenced this issue Feb 18, 2022
@RomaricMourgues
Keep company total member up to date linagora#1901
8d9866f
@RomaricMourgues RomaricMourgues mentioned this issue Feb 18, 2022
Merged
6 tasks
RomaricMourgues added a commit that referenced this issue Feb 21, 2022
@RomaricMourgues
🛠 Fix multiple bugs and update version (#1965)
10e139a 
* Fix #1818

* Fix #1963

* Fix #1861

* Fix #1964

* Fix #1790

* Keep company total member up to date #1901

* Fix frontend loop

* Version update and changelogs

* Fix tests

* No parameters

* Just one

* Remove unused and broken decorator

* Improve mentions logging

* Fix events for mentions

* Add spellcheck to editor

* Update changelog

* Using right pubsub service

* Add more logs

* More logs

* Fix typo

* Fix recent_workspaces camelcase

* Update default notification in mentions

* Fixing tests

* Fix mention specs

* Add timout

* Set notification level on creation

* Should be good

* Fix member update event
RomaricMourgues added a commit that referenced this issue Feb 21, 2022
@RomaricMourgues
🛠 Fix multiple bugs and update version (#1965)
067ffe0 
* Fix #1818

* Fix #1963

* Fix #1861

* Fix #1964

* Fix #1790

* Keep company total member up to date #1901

* Fix frontend loop

* Version update and changelogs

* Fix tests

* No parameters

* Just one

* Remove unused and broken decorator

* Improve mentions logging

* Fix events for mentions

* Add spellcheck to editor

* Update changelog

* Using right pubsub service

* Add more logs

* More logs

* Fix typo

* Fix recent_workspaces camelcase

* Update default notification in mentions

* Fixing tests

* Fix mention specs

* Add timout

* Set notification level on creation

* Should be good

* Fix member update event
@hantt12
Copy link

hantt12 commented Feb 22, 2022

System shows unfriendly message (404 error) if we add users when the company has reached the maximum number of users

2022-02-22_15-09-09.gif

@RomaricMourgues RomaricMourgues mentioned this issue Feb 22, 2022
Merged
5 tasks
@hantt12 hantt12 closed this as completed Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomaricMourgues RomaricMourgues

Labels
qa:failed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@RomaricMourgues @BenoitTallandier @stephanevieira75 @hantt12