Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor User recoil hooks #1960

Closed
6 tasks
RomaricMourgues opened this issue Feb 16, 2022 · 0 comments
Closed
6 tasks

Refactor User recoil hooks #1960

RomaricMourgues opened this issue Feb 16, 2022 · 0 comments
Assignees
@stephanevieira75

Comments

@RomaricMourgues
Copy link
Contributor

RomaricMourgues commented Feb 16, 2022 •
edited

  • Read then remove the useGetOrFetchUser, search-user.ts, selector/current-user, atoms/user-list (they are unused)
  • Use a list of users instead of a atom family
  • Create a selector to get a single user
  • A function to set the userState from different places in the app (when getting workspace users, channel members etc) (see image 1)
  • Extend the search function to get frontend results too
  • Update the useUser hook to get a user without suspense (see image 2 in case we still have await in the default)

Screenshot 2022-02-16 at 12.19.28.png

Screenshot 2022-02-16 at 12.22.15.png
@RomaricMourgues RomaricMourgues mentioned this issue Feb 22, 2022
Closed
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 4, 2022
linagora#1960 Implement users list search in frontend
bebdc53
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 4, 2022
linagora#1960 Implement users list search in frontend
7aa5e6b
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 7, 2022
linagora#1960 Implement workspace list in user object
661ac7f
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 8, 2022
linagora#1960 Implement users list search in frontend
4272461
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 8, 2022
linagora#1960 Implement workspace list in user object
7e25120
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 8, 2022
linagora#1960 Add missing translations in workspace members table
9f827f8
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 8, 2022
linagora#1960 Filter results in channel participants popup
e94b91a
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 8, 2022
linagora#1960 Add guests in user list state
f28f48a
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 9, 2022
linagora#1960 Implement users list search in frontend
040c880
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 9, 2022
linagora#1960 Implement workspace list in user object
bea5f2c
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 9, 2022
linagora#1960 Add missing translations in workspace members table
eae4097
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 9, 2022
linagora#1960 Filter results in channel participants popup
a06454f
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 9, 2022
linagora#1960 Add guests in user list state
976c600
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 9, 2022
linagora#1960 Allow mentions to use user list state
b33a878
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 10, 2022
linagora#1960 Implement users list search in frontend
16a923f
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 10, 2022
linagora#1960 Implement workspace list in user object
eb2436e
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 10, 2022
linagora#1960 Add missing translations in workspace members table
6153d15
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 10, 2022
linagora#1960 Filter results in channel participants popup
9ea2259
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 10, 2022
linagora#1960 Add guests in user list state
304c3c3
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 10, 2022
linagora#1960 Allow mentions to use user list state
abdf2d2
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 10, 2022
linagora#1960 Add ellipsis in member channel row
353d58e
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 11, 2022
linagora#1960 Implement users list search in frontend
31e83ad
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 11, 2022
linagora#1960 Implement workspace list in user object
8d1c4fc
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 11, 2022
linagora#1960 Add missing translations in workspace members table
380f169
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 11, 2022
linagora#1960 Filter results in channel participants popup
c03fb81
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 11, 2022
linagora#1960 Add guests in user list state
e9966be
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 11, 2022
linagora#1960 Allow mentions to use user list state
fda0c03
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 11, 2022
linagora#1960 Add ellipsis in member channel row
02d35fe
stephanevieira75 pushed a commit to stephanevieira75/Twake that referenced this issue Mar 11, 2022
linagora#1960 Resolve threads
1ce38dc
RomaricMourgues pushed a commit that referenced this issue Mar 21, 2022
@stephanevieira75
🌟 #1960 Implement users list search in frontend (#1996)
0abae68 
* #1960 Implement users list search in frontend

* #1960 Implement workspace list in user object

* #1960 Add missing translations in workspace members table

* #1960 Filter results in channel participants popup

* #1960 Add guests in user list state

* #1960 Allow mentions to use user list state

* #1960 Add ellipsis in member channel row

* #1960 Resolve threads
RomaricMourgues pushed a commit that referenced this issue Mar 22, 2022
@stephanevieira75
🌟 #1960 Implement users list search in frontend (#1996)
33663dd 
* #1960 Implement users list search in frontend

* #1960 Implement workspace list in user object

* #1960 Add missing translations in workspace members table

* #1960 Filter results in channel participants popup

* #1960 Add guests in user list state

* #1960 Allow mentions to use user list state

* #1960 Add ellipsis in member channel row

* #1960 Resolve threads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephanevieira75 stephanevieira75

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RomaricMourgues @shepilov @stephanevieira75