Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search box part 4 #2374

Closed
16 tasks done
RomaricMourgues opened this issue Jun 30, 2022 · 1 comment
Closed
16 tasks done

Search box part 4 #2374

RomaricMourgues opened this issue Jun 30, 2022 · 1 comment
Assignees

Comments

@RomaricMourgues
Copy link
Contributor

RomaricMourgues commented Jun 30, 2022

Bugs

  • results that matches the most of input words should comes first for channels
  • Show quickly "private channel" for channels that are not private
  • Some channels shows "you cannot access this content" for some private channels or direct channels (?)
  • When leaving channel this is not updated automatically for "isChannelMember" and search box
  • Space in channel context
  • Closed modal still has mouse interaction from @rezk2ll
  • Fix badge number of results (medias should keep showing even if no thumbnail)
  • Show channels in All in rows instead on column when searching
  • Show attachment with messages result (as we search in message attachment names too)
  • Small modal should be vertically stable (min Height + top static pos ?)
  • Download banner fixes
  • if not logged in do not try to open desktop app
  • add the try_desktop=1 to all shared links, only open the desktop app if no path or query string contain try_desktop

Backend

  • The recent channels endpoint doesn't return not joined channels
  • Add users to channels object returned by message object in search
  • Recents should use channel context
@RomaricMourgues RomaricMourgues self-assigned this Jun 30, 2022
@RomaricMourgues
Copy link
Contributor Author

@shepilov for the record, my next tasks (still a lot)

RomaricMourgues added a commit to RomaricMourgues/Twake that referenced this issue Jul 1, 2022
RomaricMourgues added a commit that referenced this issue Jul 1, 2022
* Fix #2373

* Fix #2361 #2362 #2372

* Keep showing channels in channel scope mode

* Fix some bugs from #2374

* Fix linter
RomaricMourgues added a commit that referenced this issue Jul 1, 2022
* Fix #2373

* Fix #2361 #2362 #2372

* Keep showing channels in channel scope mode

* Fix some bugs from #2374

* Fix linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant