Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote reply button doesn't focus onto the new message input #2524

Closed
hantt12 opened this issue Sep 20, 2022 · 5 comments
Closed

Quote reply button doesn't focus onto the new message input #2524

hantt12 opened this issue Sep 20, 2022 · 5 comments
Assignees
Labels
bug Something isn't working Minor

Comments

@hantt12
Copy link

hantt12 commented Sep 20, 2022

Describe the bug
When user reply to a message in direct chat, cursor should point to message text box as in channels

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://staging-web.twake.app/
  2. In a direct chat, send a message
  3. Select Reply option to the above message
  4. See error

Expected behavior
Cursor should be on message box
https://images.zenhubusercontent.com/271994210/606164fa-c3e7-4278-a2a3-ae6184d8d225/2022_09_20_18_16_14.mp4

@hantt12 hantt12 added bug Something isn't working Medium labels Sep 20, 2022
@RomaricMourgues
Copy link
Contributor

No thread replies have been disabled in direct chats on purpose following top management decision

@hantt12
Copy link
Author

hantt12 commented Sep 20, 2022

Then Reply action should be hidden
image

@RomaricMourgues
Copy link
Contributor

No because it trigger the quote-reply feature (the stuff on top of the text field)

@hantt12
Copy link
Author

hantt12 commented Sep 20, 2022

hmmm then cursor should be on text box anyway. Because user is expected to write something

@RomaricMourgues
Copy link
Contributor

Ok that I agree

@RomaricMourgues RomaricMourgues changed the title Cursor does not automatically point to message box when user replies to a message in direct chat Quote reply button doesn't focus onto the new message input Sep 20, 2022
RomaricMourgues added a commit to RomaricMourgues/Twake that referenced this issue Oct 7, 2022
RomaricMourgues added a commit to RomaricMourgues/Twake that referenced this issue Oct 7, 2022
RomaricMourgues added a commit that referenced this issue Oct 11, 2022
* Add forward menu

* Fix #2524

* Fix #2524

* Create modal

* Finish initial version

* Realtime online update

* Realtime online update

* Fix quoted message display
RomaricMourgues added a commit that referenced this issue Oct 11, 2022
* Add forward menu

* Fix #2524

* Fix #2524

* Create modal

* Finish initial version

* Realtime online update

* Realtime online update

* Fix quoted message display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Minor
Projects
None yet
Development

No branches or pull requests

3 participants