Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readonly channels option #2549

Closed
4 tasks
RomaricMourgues opened this issue Oct 3, 2022 · 5 comments
Closed
4 tasks

Readonly channels option #2549

RomaricMourgues opened this issue Oct 3, 2022 · 5 comments
Assignees

Comments

@RomaricMourgues
Copy link
Contributor

RomaricMourgues commented Oct 3, 2022

Goal of this issue is to add an option to restrict the write-ability of a channel to only moderators and the owner of the channel (invisible information that is the creator of the channel).

  • Add a button in the channel editor modal, only moderators and owner can update this value.
  • Add a field in the channel database object
  • Add the field in the channel type in frontend typescript
  • If the channel is readonly and the user is not owner and user is not moderator of the workspace then lock the input like we did for deactivated users. Note that responses to threads must still be allowed.

Note: the test to know if the user is an moderator or not is a common service: AccessRightsService.hasLevel(workspaceId, 'moderator')

@tprudentova
Copy link
Collaborator

Hi!
When writing ability is restricted, user with insufficient access gets a warning about access being restricted, however they can still create new discussions
Screenshot 2022-10-25 at 17.05.39.png

RomaricMourgues added a commit to RomaricMourgues/Twake that referenced this issue Nov 2, 2022
@RomaricMourgues
Copy link
Contributor Author

Thanks again @tprudentova ! Fixes are on their way #2591

RomaricMourgues added a commit that referenced this issue Nov 8, 2022
* Fix all from #2550

* Fix #2549

* Fix const / let

* 🛠 Do not return files that doesn't exists anymore (#2592)

* Do not return files that doesn't exists anymore

* Fix filter

* Fix displaying the forwarded message

* Fix #2593
RomaricMourgues added a commit that referenced this issue Nov 8, 2022
* Fix all from #2550

* Fix #2549

* Fix const / let

* 🛠 Do not return files that doesn't exists anymore (#2592)

* Do not return files that doesn't exists anymore

* Fix filter

* Fix displaying the forwarded message

* Fix #2593
@RomaricMourgues
Copy link
Contributor Author

Should be ready to test again

@tprudentova
Copy link
Collaborator

@RomaricMourgues hi!
On the video you can see that the second user (they’re not the owner of the company but are the creator of the chat) can send messages in a read-only chat but doesn’t have access to the chat settings thus can’t make the channel read-only. If I understand correctly, it should be either both of the features (for owners and moderators) or none (for everyone else).
https://images.zenhubusercontent.com/271994210/2d6d8b64-aaf0-4f9e-a97e-44600fea7357/screen_recording_2022_11_10_at_15_44_38.mov

@RomaricMourgues
Copy link
Contributor Author

RomaricMourgues commented Nov 14, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants