-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌟 Added remove link preview #2238
Conversation
Perfect, I'll review the code itself tomorrow |
@shepilov so this was the last part of this feature according to me, could be nice to get the design from @BastiaanVanGaalen here too to finalise for real |
@rezk2ll I forgot to ask, on the video it seems a bit slow to generate the links, do you have any idea what is taking much of this time ? Is it rabbitmq stuff or downloading the content of the link ? |
there is no downloading happening, just HTML parsing and 1 call to get the favicon I recorded another video it took about ~4 seconds for the preview to be displayed. from the console, I think most of the time is spent on parsing the HTML of the URL. preview-test-speed.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Co-authored-by: Romaric Mourgues <rmourgues@linagora.com>
Description
Related Issue
#2235
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
removeLinkPreview.mp4
Types of changes
Checklist: