Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃搧 #2752 fixed breadcrumb navigation overflow #2753

Merged
merged 2 commits into from Feb 21, 2023

Conversation

rezk2ll
Copy link
Member

@rezk2ll rezk2ll commented Feb 21, 2023

Description

  • changed the style of the breadcrumb navigation to remove the overflow and wrap the elements.

Related Issue

#2752

Motivation and Context

solves a UI issue with the breadcrumb navigation having an overflow:

image

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

while connected:

image

incognito / shared folder:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@rezk2ll rezk2ll linked an issue Feb 21, 2023 that may be closed by this pull request
@RomaricMourgues
Copy link
Contributor

H茅h茅 if we do that the we have a new problem if there is too many folders no ?
The solution is probably to do this kind of "..." menu, but it's slower.

An overflow-auto should work in the meanwhile but only if the paddings / marings are OK (the overflow auto should not display scroll bar if the content isn't bigger that the container). So I think we should look at this issue instead of putting a overflow-hidden. What do you think ?

Screenshot 2023-02-21 at 10 43 10

@rezk2ll
Copy link
Member Author

rezk2ll commented Feb 21, 2023

@RomaricMourgues we can also make the middle elements shrink instead.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Drive] Fix breadcrumb navigation ui issues
2 participants