Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the functions of the options of the channels #589

Merged
merged 1 commit into from Nov 26, 2020

Conversation

RkAiman
Copy link
Contributor

@RkAiman RkAiman commented Nov 26, 2020

No description provided.

submenu: [
{
text: Languages.t('scenes.apps.messages.left_bar.stream.notifications.all'),
icon: 'check',
icon: props.channel.user_member?.notification_level === 'all' && 'check',
onClick: () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using curly brackets (which means you need to return something) you could do this inline:

(param: any) => //inline

or

(param: any) => {
 return //something ;
}

]),
icon: props.channel.user_member?.notification_level === 'group_mentions' && 'check',
onClick: () => {
changeNotificationPreference('group_mentions');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

]),
icon: props.channel.user_member?.notification_level === 'user_mentions' && 'check',
onClick: () => {
changeNotificationPreference('user_mentions');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too

{
text: Languages.t('scenes.apps.messages.left_bar.stream.notifications.never'),
icon: props.channel.user_member?.notification_level === 'none' && 'check',
onClick: () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here 👍

@RomaricMourgues RomaricMourgues merged commit 6454568 into linagora:feature/2020.Q4.dev Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants