JAMES-2150 Added the ability to upload Sieve scripts via the CLI #1828

matzepan · 2018-10-20T18:15:13Z

Implemented the steps described in JAMES-2150

chibenwa · 2018-10-23T01:27:26Z

server/container/cli/src/main/java/org/apache/james/cli/type/CmdType.java

@@ -62,7 +62,8 @@
    REMOVESIEVEQUOTA("RemoveSieveQuota"),
    GETSIEVEUSERQUOTA("GetSieveUserQuota", "username"),
    SETSIEVEUSERQUOTA("SetSieveUserQuota", "username", "quota"),
-    REMOVESIEVEUSERQUOTA("RemoveSieveUserQuota", "username");
+    REMOVESIEVEUSERQUOTA("RemoveSieveUserQuota", "username"),
+    ADDACTIVESIEVESCRIPT("AddActiveSieveScript", "username", "scriptname", "script");


Passing a SIEVE script directly as a bash script parameter seems like a bad idea to me... A sieve script is a multiline, potentially long string.

IMO we should do like in MailboxManagerManagement::importEmlFileToMailbox: rely on the file path rather than on the full string.

rouazana · 2018-10-23T08:30:37Z

server/container/cli/src/main/java/org/apache/james/cli/ServerCmd.java

@@ -331,6 +331,9 @@ private void executeCommand(String[] arguments, CmdType cmdType, PrintStream pri
        case REMOVESIEVEUSERQUOTA:
            sieveProbe.removeSieveQuota(arguments[1]);
            break;
+            case ADDACTIVESIEVESCRIPT:


this case should be indented as the previous one

chibenwa · 2018-10-23T08:54:29Z

I am relaunching the CI build on your pull request

test this please

matzepan · 2018-10-23T18:46:38Z

I added the ability to load from a file - but I have to say that I am quite confused what the difference between SieveRepositoryManagement and SieveProbeImpl should be. Looks like quite the duplicate functionality.

chibenwa · 2018-10-24T00:51:12Z

server/container/cli/src/main/java/org/apache/james/cli/ServerCmd.java

-        this.mailboxProbe = mailboxProbe;
-        this.quotaProbe = quotaProbe;
-        this.sieveProbe = sieveProbe;
-    }


That is unfortunate: we tend to put static methods first, then fields, then the constructor, then the methods.

You also moved by mistake in a similar way print and printUsage below.

Could you restore the original ordering of these methods?

I did a Rearrange Code in Intellij which i thought used the checkstyle to rearrange the code accordingly. Reverting it :)

.../protocols/managedsieve/src/main/java/org/apache/james/modules/protocols/SieveProbeImpl.java

...ta-library/src/main/java/org/apache/james/sieverepository/lib/SieveRepositoryManagement.java

...ibrary/src/test/java/org/apache/james/sieverepository/lib/SieveRepositoryManagementTest.java

chibenwa · 2018-10-24T01:14:41Z

I added the ability to load from a file - but I have to say that I am quite confused what the difference between SieveRepositoryManagement and SieveProbeImpl should be. Looks like quite the duplicate functionality.

Very true.

Note that probes and Management APIs needs to exist: they serve different functionalities:

Management and MBean is for some JMX semantic. We do not want it to leak further in the project
Probes are a way to interact with a James server. We do rely on them in some tests.

However many of them have duplicate capabilities. Maybe we could have the management stuff calling the probe directly?

trantienduchn · 2018-10-25T02:57:40Z

no build result, test this please

chibenwa · 2018-10-25T03:30:49Z

We recently did some modifications to the merging tool that runs before the pull request build.

In order to benefit from it, and start the tests, you need to rebase on linagora/master then force push your changes here.

Can I let you do it?

Many thanks!

…d autoformat

matzepan · 2018-10-26T18:42:37Z

Rebase is complete.

chibenwa · 2018-10-29T12:16:46Z

Hi,

This pull request has just been merged.

Thank you again for your dedication toward the James project. If you need help, want to contribute documentation, new features, tests or bugfix, please don't hesitate to reach us.

Thanks again,

Cheers,

Benoit

chibenwa added the contribution Contribution of a kind contributor - also applicable for community oriented efforts. label Oct 23, 2018

chibenwa added this to the polish_2018_10 milestone Oct 23, 2018

chibenwa reviewed Oct 23, 2018

View reviewed changes

rouazana reviewed Oct 23, 2018

View reviewed changes

chibenwa mentioned this pull request Oct 23, 2018

JAMES-2150 Added the ability to upload Sieve scripts via the CLI #1844

Closed