Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tzinfo to UTC #5

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Fix tzinfo to UTC #5

merged 1 commit into from
Feb 5, 2020

Conversation

hieki
Copy link
Contributor

@hieki hieki commented Jan 21, 2020 •
edited
Loading

In time zones other than UTC, expiration dates cannot be compared correctly.
datetime objects should be aware.

I got this

$ aws2-wrap --profile MY_PROFILE --exec "terraform plan"
Please login with 'aws2 sso login --profile=MY_PROFILE'

@sonarcloud
Copy link

sonarcloud bot commented Jan 21, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hieki
Copy link
Contributor Author

hieki commented Jan 26, 2020 •
edited
Loading

@pcolmer
Hi!
Thanks for the useful tool.
Under different time zones, I found a problem.
Can you check it out? 🙏

@pcolmer pcolmer merged commit 81a4a4e into linaro-its:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcolmer pcolmer pcolmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hieki @pcolmer