raw secure storage accesses #5

etienne-lms · 2017-09-07T15:41:39Z

secure_storage example provides basics for creating, reading and deleting
a object in a TA secure storage.

A TA command allows to create an object in the TA secure storage.
A TA command allows to read an object in the TA secure storage.
A TA command allows to delete an object from the TA secur storage.

This example does not cover all the possibilities of secure storage API
provided to TAs: seeking into a object data stream, manipulating
key material objects instead of raw data objects, etc.

jbech-linaro · 2017-10-11T13:13:30Z

secure_storage/Android.mk

+		$(OPTEE_CLIENT_EXPORT)/include \
+
+LOCAL_SHARED_LIBRARIES := libteec
+LOCAL_MODULE := tee_example_secure_storage


I think we should prefix all optee_example files with somethings like ote_<module> (OP-TEE Example).

jbech-linaro · 2017-10-11T13:22:05Z

secure_storage/Makefile

@@ -0,0 +1,15 @@
+export V?=0


s/export V?=0/export V ?= 0/

jbech-linaro · 2017-10-11T13:23:20Z

secure_storage/host/Makefile

+#Add/link other required libraries here
+LDADD += -lteec -L$(TEEC_EXPORT)/lib
+
+BINARY = optee_secure_storage


Same here as for the module in the Android make files, ... ote_<module>. At least we should have the same name in both Android and Linux.

jbech-linaro · 2017-10-11T13:29:19Z

secure_storage/host/main.c

+	if (res != TEEC_SUCCESS)
+		errx(1, "Failed to create an object in the secure storage");
+
+	printf("- Read back the but in a too small buffer (should fail)\n");


I don't think it is a good idea to show this in an example like this. This smells a bit more of a test case than just showing how to do things. I would just skip this and go directly with the well sized buffer.

However, if you insist of keeping this part, then I think you should at least check/use the params[1].memref.size which contains the expected size when TEEC_ERROR_SHORT_BUFFER is returned (at least that is what you are doing in the TA).

I will remove the test case.

jbech-linaro · 2017-10-11T13:31:03Z

secure_storage/host/main.c

+	if (res != TEEC_SUCCESS)
+		errx(1, "Failed to delete the object: 0x%x", res);
+
+	printf("- Try to access the object (should fail)\n");


Same here, I would skip this "should fail" section.

jbech-linaro · 2017-10-11T13:37:38Z

secure_storage/ta/user_ta_header_defines.h

+
+#define TA_CURRENT_TA_EXT_PROPERTIES \
+    { "gp.ta.description", USER_TA_PROP_TYPE_STRING, \
+        "Exmaple of TA writing/reading data from its secure storage" }, \


s/Exmaple/Example/

jbech-linaro · 2017-10-11T13:38:07Z

secure_storage/ta/user_ta_header_defines.h

+
+#include <secure_storage_ta.h>
+
+#define TA_UUID				TA_SECURE_STORAGE_UUID


Should we use the same idea here? OTE_<module>_UUID?

etienne-lms · 2017-10-17T15:27:45Z

comments addressed.

sahilnxp · 2017-10-27T15:08:29Z

secure_storage/host/main.c

+	res = read_secure_object(&ctx, obj1_id,
+				 read_data, sizeof(read_data));
+	if (res != TEEC_SUCCESS)
+		errx(1, "Failed to create an object in the secure storage");


Here Error message should be "Failed to read an object".

etienne-lms · 2017-11-08T10:41:58Z

Rebased on top of #8 and #3.

etienne-lms · 2017-11-10T10:50:03Z

Rebased on master.

jforissier

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

jforissier · 2017-11-10T14:53:04Z

secure_storage/host/Makefile

+NM      = $(CROSS_COMPILE)nm
+OBJCOPY = $(CROSS_COMPILE)objcopy
+OBJDUMP = $(CROSS_COMPILE)objdump
+READELF = $(CROSS_COMPILE)readelf


Only CC is needed it seems

Kept for consistency with other. Will clean all in a later change if better.

etienne-lms · 2018-07-10T07:47:19Z

Rebased, tag applied.

jenswi-linaro · 2018-07-10T07:47:07Z

.gitignore

@@ -17,3 +17,4 @@ hello_world/host/optee_example_hello_world
 random/host/optee_example_random
 aes/host/optee_example_aes
 hotp/host/optee_example_hotp
+secure_storage/host/optee_example_secure_storag


Is an e missing at the end?

Good catch. i don't know how I corrupted that!
Thanks.

jenswi-linaro · 2018-07-10T08:40:12Z

Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

This change provides basics for creating, reading and deleting an object in a TA secure storage. The TA implementation shows how to use the GPD TEE Internal Core API for some basic data persistent object manipulations. A TA command allows to create an object in the TA secure storage. A TA command allows to read an object in the TA secure storage. A TA command allows to delete an object from the TA secure storage. This example does not cover all the possibilities of secure storage API provided to TAs: seeking into a object data stream, manipulating key material objects instead of raw data objects, etc. Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> Acked-by: Jerome Forissier <jerome.forissier@linaro.org> Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

etienne-lms · 2018-07-10T09:12:38Z

Squashed, commit description fixed, tags applied.
Thanks

jbech-linaro reviewed Oct 11, 2017

View reviewed changes

secure_storage/Makefile Outdated

@@ -0,0 +1,15 @@

export V?=0

Copy link

Contributor

jbech-linaro Oct 11, 2017 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/export V?=0/export V ?= 0/

jbech-linaro reviewed Oct 11, 2017

View reviewed changes

jbech-linaro mentioned this pull request Oct 26, 2017

Not able to Open Persistent Object OP-TEE/optee_test#232

Closed

sahilnxp reviewed Oct 27, 2017

View reviewed changes

vchong mentioned this pull request Nov 2, 2017

Can a .SO file be called by TA? OP-TEE/optee_os#1909

Closed

etienne-lms force-pushed the secure-storage-raw branch from eb826f9 to 9a5c415 Compare November 7, 2017 22:28

etienne-lms mentioned this pull request Nov 8, 2017

OTE for Op-Tee Examples #8

Closed

etienne-lms force-pushed the secure-storage-raw branch from 9a5c415 to ea22eff Compare November 8, 2017 10:36

etienne-lms force-pushed the secure-storage-raw branch 3 times, most recently from f9b948c to 7a830ac Compare November 10, 2017 10:49

jforissier reviewed Nov 10, 2017

View reviewed changes

etienne-lms force-pushed the secure-storage-raw branch 2 times, most recently from 46d63c8 to 3318005 Compare July 10, 2018 07:45

jenswi-linaro reviewed Jul 10, 2018

View reviewed changes

etienne-lms force-pushed the secure-storage-raw branch from 7eab96e to 8c75c23 Compare July 10, 2018 09:11

jenswi-linaro merged commit ae02c09 into linaro-swg:master Jul 10, 2018

etienne-lms deleted the secure-storage-raw branch November 14, 2019 08:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

raw secure storage accesses #5

raw secure storage accesses #5

etienne-lms commented Sep 7, 2017

jbech-linaro Oct 11, 2017

jbech-linaro Oct 11, 2017 •

edited

Loading

jbech-linaro Oct 11, 2017

jbech-linaro Oct 11, 2017 •

edited

Loading

jbech-linaro Oct 11, 2017 •

edited

Loading

etienne-lms Oct 17, 2017

jbech-linaro Oct 11, 2017

etienne-lms Oct 17, 2017

jbech-linaro Oct 11, 2017

jbech-linaro Oct 11, 2017

etienne-lms commented Oct 17, 2017

sahilnxp Oct 27, 2017

etienne-lms commented Nov 8, 2017

etienne-lms commented Nov 10, 2017

jforissier left a comment

jforissier Nov 10, 2017

etienne-lms Jul 10, 2018

etienne-lms commented Jul 10, 2018

jenswi-linaro Jul 10, 2018

etienne-lms Jul 10, 2018

jenswi-linaro commented Jul 10, 2018

etienne-lms commented Jul 10, 2018


		#include <secure_storage_ta.h>

		#define TA_UUID TA_SECURE_STORAGE_UUID

raw secure storage accesses #5

raw secure storage accesses #5

Conversation

etienne-lms commented Sep 7, 2017

Choose a reason for hiding this comment

jbech-linaro Oct 11, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jbech-linaro Oct 11, 2017 • edited Loading

Choose a reason for hiding this comment

jbech-linaro Oct 11, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

etienne-lms commented Oct 17, 2017

Choose a reason for hiding this comment

etienne-lms commented Nov 8, 2017

etienne-lms commented Nov 10, 2017

jforissier left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

etienne-lms commented Jul 10, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jenswi-linaro commented Jul 10, 2018

etienne-lms commented Jul 10, 2018

jbech-linaro Oct 11, 2017 •

edited

Loading

jbech-linaro Oct 11, 2017 •

edited

Loading

jbech-linaro Oct 11, 2017 •

edited

Loading