Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing --enable-doc=no or --disable-doc still enables the documentation #148

Closed
orlitzky opened this issue Jan 1, 2020 · 0 comments · Fixed by #167
Closed

Passing --enable-doc=no or --disable-doc still enables the documentation #148

orlitzky opened this issue Jan 1, 2020 · 0 comments · Fixed by #167

Comments

@orlitzky
Copy link
Contributor

orlitzky commented Jan 1, 2020

Given that AC_ARG_ENABLE is for boolean flags, its user interface doesn't match up with its intended purpose very well. Instead of two yes/no branches, the macro really gives you two present/absent branches, and you have to test the (boolean) value of the flag yourself in the "present" branch.

As a result, the --enable-doc flag doesn't work quite the way that you'd expect. In https://github.com/linbox-team/givaro/blob/master/macros/givaro-doc.m4#L39, that test enables the documentation whenever the --enable-doc flag is present. But the flag is "present" even when the user passes --disable-doc, or the equivalent --enable-doc=no. In those cases, the documentation should obviously not be built.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant