Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTC setting improvement via push button menu #157

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

zymurgic
Copy link
Contributor

@zymurgic zymurgic commented Feb 8, 2023

If Real-Time Clock isn't set, and if we're not setting via the wifi module then the YEAR_MIN should now be a bit more recent to save button pushes. Perhaps YEAR_MAX for the pushbutton menu interface should be more than 10 years later? What's the expected lifespan of this system before we'd expect firmware updates to be applied?

If Real-Time Clock isn't set, and if we're not setting via the wifi module then the YEAR_MIN should now be a bit more recent to save button pushes.
Perhaps YEAR_MAX for the pushbutton menu interface should be more than 10 years later? What's the expected lifespan of this system before we'd expect firmware updates to be applied?
Copy link
Owner

@lincomatic lincomatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a trade off between convenience of not having to cycle through too many years if you overshoot and adding years to the menu. it's open source... you're free to change the parameters to suit yourself. thank you

@lincomatic lincomatic merged commit 823162f into lincomatic:master Feb 8, 2023
@zymurgic zymurgic deleted the patch-2 branch March 7, 2023 15:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants