Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes dock icon #94

Closed
wants to merge 2 commits into from
Closed

Removes dock icon #94

wants to merge 2 commits into from

Conversation

MScottBlake
Copy link
Contributor

Removes the dock icon to address #10.

Without a dock icon, there is no need for a main menu, so that is removed as well.

Scott Blake added 2 commits August 3, 2014 03:01
Set the UIElement setting to true to address #10.
Since there is no dock icon to select, the main menu is no longer
needed. (Relates to #10)
@eahrold
Copy link
Collaborator

eahrold commented Aug 3, 2014

I do like the idea of setting the LSUIElement to true, especially since your other pull request fixed the bring window to front issue.

I'm not sure we should completely remove the MainMenu.xib just yet. I just did a pull that takes the NSMenu in there and wires it up rather than needing to do that in code. And there may be some future need for that.

@MScottBlake
Copy link
Contributor Author

This is specifically why they were made into 2 different commits. The ability to let you decide.

@eahrold
Copy link
Collaborator

eahrold commented Aug 3, 2014

I understand, since I'm not a maintainer I'm just weighing in. I'll leave it to @futureimperfect to decide how to proceed.

@futureimperfect
Copy link
Collaborator

Hi Scott and Eldon,

I've been wanting to set LSUIElement to true, but haven't yet because I thought I needed to run a helper app to get AutoPkgr to display the configuration window when the user clicks "Configure." I could be completely mistaken about this because it's been a while since I tried, (it might even have been for another project).

Here's how I'd like AutoPkgr's UI/UX to work:

  1. Upon first launch, display the configuration window, (or maybe in the future something more like a setup assistant, similar to Dropbox).
  2. Don't show the Dock icon, (LSUIElement = True)
  3. Don't show the configuration window after the initial setup is completed, (or perhaps, make this optional).

Can we do the above without removing MainMenu.xib?

Thanks!

@MScottBlake
Copy link
Contributor Author

Yes it can. I'm not real familiar with the PR system, but that's specifically why I made them 2 different commits.

If you can't separate them, I can make a new PR with just the one where there is no dock icon, but without touching the MainMenu.xib

@eahrold
Copy link
Collaborator

eahrold commented Aug 4, 2014

We should also make sure to bind this to a menu option/control/command key, so you can still get an about panel.

 [[NSApplication sharedApplication]orderFrontStandardAboutPanel:self];

@futureimperfect
Copy link
Collaborator

Hi Eldon,

Feel free to make whatever changes you need to this branch and let me know when It's ready for testing/merging.

Thank you.

@loyaltyarm
Copy link

Is there any reason you guys wouldn't bind Configure... in the NSMenu to the window's (MainMenu.xib) orderFront? You can set LSUIElement = True, bind the NSMenuItem for Configure to MainMenu.xib's orderFront, then use Interface Builder setting (checkbox) under the Attributes Inspector for the NSWindow (the Configure screen of MainMenu.xib), to set 'Visible at Launch' to TRUE.

If this is complicated in explanation I can pull and complete this change.

@eahrold eahrold added this to the 1.2 milestone Nov 6, 2014
@eahrold
Copy link
Collaborator

eahrold commented Nov 6, 2014

@loyaltyarm Some of this is artifact from 1.0 release and just worked since.

In the upcoming 1.2 release I hope to finally use a system launchd to control the scheduling of AutoPkgr so a status menu item may become unnecessary, and we may remove it (I'm sure there will be debate). Either way something will give way w/ 1.2 ,either the menu item or the dock item.

We don't bind the configure menu to orderFront because we need to init a separate .xib. Also the window is not the MainMenu's window, it's the LGConfigurationWindowController.xib

In addition the only place the sparkle update is is in the main menu.

So keeping in mind those things, we love PR's. If you can put together a better way of doing this please submit.

@eahrold eahrold mentioned this pull request Dec 2, 2014
@homebysix
Copy link
Collaborator

This is built into 1.2 now. Thanks!

@homebysix homebysix closed this Feb 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants