Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting barcode height fails if set from a string value #113

Closed
swegen opened this issue Nov 6, 2016 · 3 comments
Closed

Setting barcode height fails if set from a string value #113

swegen opened this issue Nov 6, 2016 · 3 comments

Comments

@swegen
Copy link

swegen commented Nov 6, 2016

jsbin example
This library should use parseInt() internally to be more robust.
lindell added a commit that referenced this issue Nov 6, 2016
@lindell
Make sure strings are converted to numbers / booleans with normal use #…
fd1ad1b 
…113
@lindell
Copy link
Owner

lindell commented Nov 6, 2016 •
edited
Loading

Pushed JsBarcode v3.5.5 to deal with this.

@lindell
Copy link
Owner

lindell commented Nov 6, 2016

http://jsbin.com/zifexozacu/edit?html,output

@swegen
Copy link
Author

swegen commented Nov 6, 2016

Fast fix! Thank you for this nice project.

@lindell lindell closed this as completed Nov 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lindell @swegen