Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including all upstream salt as an additional attribute. Note that the download of catchments is still failing for one group of NHD COMIDs and I have chosen to just skip for now. I am working through the issues here: DOI-USGS/nhdplusTools#376.
There is now an additional attribute in the
p3_static_attributes
target calledattr_roadSaltCumulative
which represents the aggregate salt for the current site's catchment and all of the catchments upstream from it.Below are some snapshots of the new upstream data compared to the catchment-only salt. Note that for these plots, I first filtered any site where
upstream
was missing. There are 11 sites where cumulative is the same as catchment roadSalt, meaning they are the headwaters reach (ratio == 1 in the histogram). Most sites have less than half of the cumulative upstream salt applied in their individual catchment, which is expected.