Add ClientRequestContextBuilder and ServiceRequestContextBuilder
#1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1548 +/- ##
============================================
- Coverage 72.62% 72.48% -0.15%
- Complexity 7249 7313 +64
============================================
Files 677 681 +4
Lines 29326 29628 +302
Branches 3579 3601 +22
============================================
+ Hits 21299 21475 +176
- Misses 6177 6276 +99
- Partials 1850 1877 +27
Continue to review full report at Codecov.
|
anuraaga
reviewed
Jan 23, 2019
core/src/main/java/com/linecorp/armeria/client/ClientRequestContext.java
Show resolved
Hide resolved
anuraaga
reviewed
Jan 23, 2019
| /** | ||
| * Returns a new {@link ClientRequestContextBuilder} created from the specified {@link RpcRequest} and URI. | ||
| */ | ||
| public static ClientRequestContextBuilder of(RpcRequest request, String uri) { |
There was a problem hiding this comment.
Why does ClientRequestContextBuilder accept RpcRequest but not ServiceRequestContextBuilder? If the use case is for a server that processes messages from Kafka, for example, it seems like a service (the client is whoever published the message).
There was a problem hiding this comment.
Because a ServiceRequestContext's request has been always an HttpRequest? For instance, ServiceRequestContext.service() always returns Service<HttpRequest, HttpResponse>. We may want to change this if we support more than HTTP but I guess it would be hard to occur at the moment.
There was a problem hiding this comment.
In that case what would it look like to model the kafka request with ServiceRequestContext? Would it need a dummy HTTP request? I'm trying to understand how this will solve the use case, at first I expected to create a ServiceRequestContext with RpcRequest.of(KafkaService.class or something
There was a problem hiding this comment.
Yes, a dummy HTTP request will be required. A user may want to set some custom attributes as well.
minwoox
reviewed
Jan 23, 2019
core/src/main/java/com/linecorp/armeria/client/ClientRequestContext.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/common/AbstractRequestContextBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/common/AbstractRequestContextBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/common/logging/RequestLogBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/common/logging/RequestLogBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/common/logging/RequestLogBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/common/logging/RequestLogBuilder.java
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/common/logging/RequestLogBuilder.java
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/common/util/EventLoopGroups.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/server/DefaultServiceRequestContext.java
Outdated
Show resolved
Hide resolved
Motivation: - It is often hard to create a mock of a `RequestContext`. - Sometimes a user want to emulate an incoming request and feed it into his or her processing pipeline. Modifications: - Added `AbstractRequestContextBuilder`. - Added `ClientRequestContextBuilder`. - Added `ServiceRequestContextBuilder`. - Added more variants of `startRequest()`, `endRequest()`, `startResponse()` and `endResponse()` to `RequestLogBuilder` so that a user can specify exact timestamps for easier matching. - Updated most test cases to use the builder instead of mocks. Result: - Closes line#1464
minwoox
reviewed
Jan 24, 2019
core/src/main/java/com/linecorp/armeria/common/logging/RequestLogBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/common/logging/RequestLogBuilder.java
Outdated
Show resolved
Hide resolved
...ure/src/test/java/com/linecorp/armeria/spring/web/reactive/ArmeriaServerHttpRequestTest.java
Outdated
Show resolved
Hide resolved
|
Added documentation. Preview: |
hyangtack
approved these changes
Jan 24, 2019
core/src/test/java/com/linecorp/armeria/internal/annotation/AnnotatedValueResolverTest.java
Outdated
Show resolved
Hide resolved
minwoox
reviewed
Jan 24, 2019
|
Thanks for reviewing. |
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
…ine#1548) Motivation: - It is often hard to create a mock of a `RequestContext`. - Sometimes a user want to emulate an incoming request and feed it into his or her processing pipeline. For example, if a user implemented complex logic which pulls some common information like socket addresses and custom attributes from `RequestContext`, the user might want to create a `ServiceRequestContext` for a request which was streamed from other source than Armeria, such as a Kafka queue. Modifications: - Added `AbstractRequestContextBuilder`. - Added `ClientRequestContextBuilder`. - Added `ServiceRequestContextBuilder`. - Added more variants of `startRequest()`, `endRequest()`, `startResponse()` and `endResponse()` to `RequestLogBuilder` so that a user can specify exact timestamps for easier matching. - Added `RequestLog.sslSession()` - Updated most test cases to use the builder instead of mocks. Result: - Closes line#1464
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
RequestContext.his or her processing pipeline. For example, if a user implemented complex
logic which pulls some common information like socket addresses and custom
attributes from
RequestContext, the user might want to create aServiceRequestContextfor a request which was streamed from other sourcethan Armeria, such as a Kafka queue.
Modifications:
AbstractRequestContextBuilder.ClientRequestContextBuilder.ServiceRequestContextBuilder.startRequest(),endRequest(),startResponse()andendResponse()toRequestLogBuilderso that auser can specify exact timestamps for easier matching.
RequestLog.sslSession()Result: