Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ClientRequestContextBuilder and ServiceRequestContextBuilder #1548

Merged
merged 6 commits into from
Jan 28, 2019
Merged

Add ClientRequestContextBuilder and ServiceRequestContextBuilder #1548

merged 6 commits into from
Jan 28, 2019

Commits on Jan 24, 2019

  1. Add ClientRequestContextBuilder and ServiceRequestContextBuilder 

    Motivation:

- It is often hard to create a mock of a `RequestContext`.
- Sometimes a user want to emulate an incoming request and feed it into
  his or her processing pipeline.

Modifications:

- Added `AbstractRequestContextBuilder`.
- Added `ClientRequestContextBuilder`.
- Added `ServiceRequestContextBuilder`.
- Added more variants of `startRequest()`, `endRequest()`,
  `startResponse()` and `endResponse()` to `RequestLogBuilder` so that a
  user can specify exact timestamps for easier matching.
- Updated most test cases to use the builder instead of mocks.

Result:

- Closes line#1464
    @trustin
    trustin committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    0a3f60e View commit details
    Browse the repository at this point in the history

  2. Address the comments from @minwoox

    @trustin
    trustin committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    d417ded View commit details
    Browse the repository at this point in the history

  3. Address the comments from @minwoox 2

    @trustin
    trustin committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    d243310 View commit details
    Browse the repository at this point in the history

  4. Add documentation

    @trustin
    trustin committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    7d496c4 View commit details
    Browse the repository at this point in the history

  5. Address the comments from @hyangtack and @minwoox

    @trustin
    trustin committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    d735316 View commit details
    Browse the repository at this point in the history

  6. build -> building

    @trustin
    trustin committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    b447f88 View commit details
    Browse the repository at this point in the history