Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
ClientRequestContextBuilder
andServiceRequestContextBuilder
#1548Add
ClientRequestContextBuilder
andServiceRequestContextBuilder
#1548Changes from all commits
0a3f60e
d417ded
d243310
7d496c4
d735316
b447f88
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does
ClientRequestContextBuilder
acceptRpcRequest
but notServiceRequestContextBuilder
? If the use case is for a server that processes messages from Kafka, for example, it seems like a service (the client is whoever published the message).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because a
ServiceRequestContext
's request has been always anHttpRequest
? For instance,ServiceRequestContext.service()
always returnsService<HttpRequest, HttpResponse>
. We may want to change this if we support more than HTTP but I guess it would be hard to occur at the moment.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case what would it look like to model the kafka request with
ServiceRequestContext
? Would it need a dummy HTTP request? I'm trying to understand how this will solve the use case, at first I expected to create aServiceRequestContext
withRpcRequest.of(KafkaService.class
or somethingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, a dummy HTTP request will be required. A user may want to set some custom attributes as well.