-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AnnotatedHttpService: Allow @PathPrefix
annotations in class scope
#2031
Comments
That's a good idea. We currently use
I prefer the second option, but what do you think? /cc @ikhoon @minwoox |
I think |
+1 for |
Hi, Is this something a first timer can work on? If yes, I'm more that happy to look at it. I think I could read value inside armeria/core/src/main/java/com/linecorp/armeria/internal/annotation/AnnotatedHttpServiceFactory.java Line 274 in 883826f
/ .
|
@sivaalli Thanks for your opinion! |
@Path
annotations in class scope@PathPrefix
annotations in class scope
Adding @PathPrefix annotation for a user to declare a prefix path that a service object handles. Motivation: line#2031 This PR allows a user to declare a ``` ServerBuilder sb = new ServerBuilder(); sb.annotatedService(new ForBarService()); ``` and ``` @PathPrefix("/foo") public class FooBarService { @get("/bar") public Object barGet() { ... } } ``` Result: Fixes line#2031
Adding @PathPrefix annotation for a user to declare a prefix path that a service object handles. Motivation: line#2031 This PR allows a user to declare a ``` ServerBuilder sb = new ServerBuilder(); sb.annotatedService(new ForBarService()); ``` and ``` @PathPrefix("/foo") public class FooBarService { @get("/bar") public Object barGet() { ... } } ``` Result: Fixes line#2031
I think it would be nice to be able to specify a prefix as an annotation without using pathPrefix.
For example.
I think there is an advantage to see the specified path at once.
The text was updated successfully, but these errors were encountered: