-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying the port (or nic) for Spring Boot Actuator #2408
Labels
Milestone
Comments
In spring boot actuator, the base path of the provided actuator is |
@heowc Yes. It'd be nice to provide this feature as a part of the core, too. |
trustin
pushed a commit
that referenced
this issue
Jun 4, 2020
…2502) Motivation: `WebOperationService` is currently always bound to `Server`'s all ports. It'd be nice if there's a way to limit/disable `WebOperationService` for other ports than a specific port/remoteAddr/NIC. Armeria currently is not capable of binding a service to a specific port only, but we could simply respond with 404 if the request came from a wrong port. Internally this could be implemented as a generic decorator that works for any `HttpService`. Modifications: - Copy `ArmeriaSetting` to `boot-actuator-autoconfigure` - If `management.server.port` is set, protect all services under `/internal/` and actuator services on other ports. - If `management.server.port` is set, support `@LocalManagementPort` - Add test Result: - Fixes #2408
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this issue
Sep 19, 2020
…ine#2502) Motivation: `WebOperationService` is currently always bound to `Server`'s all ports. It'd be nice if there's a way to limit/disable `WebOperationService` for other ports than a specific port/remoteAddr/NIC. Armeria currently is not capable of binding a service to a specific port only, but we could simply respond with 404 if the request came from a wrong port. Internally this could be implemented as a generic decorator that works for any `HttpService`. Modifications: - Copy `ArmeriaSetting` to `boot-actuator-autoconfigure` - If `management.server.port` is set, protect all services under `/internal/` and actuator services on other ports. - If `management.server.port` is set, support `@LocalManagementPort` - Add test Result: - Fixes line#2408
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
WebOperationService
is currently always bound toServer
's all ports. It'd be nice if there's a way to limit/disableWebOperationService
for other ports than a specific port/remoteAddr/NIC.Armeria currently is not capable of binding a service to a specific port only, but we could simply respond with 404 if the request came from a wrong port. Internally this could be implemented as a generic decorator that works for any
HttpService
.As a workaround, a user can specify a custom route decorator:
The text was updated successfully, but these errors were encountered: