Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Curator X discovery and others #2673

Closed
minwoox opened this issue Apr 23, 2020 · 0 comments · Fixed by #2791
Closed

Support Curator X discovery and others #2673

minwoox opened this issue Apr 23, 2020 · 0 comments · Fixed by #2791
Labels
new feature
Milestone
0.99.7

Comments

@minwoox
Copy link
Member

minwoox commented Apr 23, 2020

Currently, We support service discovery with Zookeeper using our own format, which means that it's not compatible with others such as:

In order to be the framework well suited everywhere, We should generalize and provide a way to use whatever a user wants.
@minwoox minwoox added this to the 1.0.0 milestone Apr 23, 2020
minwoox added a commit to minwoox/armeria that referenced this issue May 29, 2020
@minwoox
Support Curator-X-Discovery and Spring Cloud ZooKeeper
f8320de 
Motivation:
Related line#2673.
It will be nice if we support Curator-X-Discovery and Spring Cloud Zookeeper.

Modifications:
- Add `InstanceSpec` and `DiscoverySpec` to specify whether use default format or Curator compatible format.
- (Breaking)
  - `NodeValueCodec` is gone.
    - You now have to use `InstanceSpec` and `DiscoverySpec` to encode and decode.
    - `ZooKeeperEndpointGroupBuilder.codec(...)` and `ZooKeeperUpatingListenerBuilder.codec(...)` are gone as well.

Result:
- You can now use Armeria client and server with Curator-X-Discovery.
@minwoox minwoox mentioned this issue May 29, 2020
Merged
trustin pushed a commit that referenced this issue Jun 3, 2020
@minwoox
Support Curator Service Discovery and Spring Cloud ZooKeeper (#2749)
7fe6daf 
Related: #2673

Motivation:

It will be nice if we support Curator Service Discovery and Spring Cloud Zookeeper.

Modifications:
- Add `ZookeeperRegistrationSpec` and `ZookeeperDiscoverySpec` to specify whether use legacy format or Curator compatible format.
  - (Breaking) You should specify `ZookeeperRegistrationSpec` When creating `ZookeeperUpdatingListener`.
  - (Breaking) You should specify `ZookeeperDiscoverySpec` When creating `ZookeeperEndpointGroup`.
- (Breaking)
  - `NodeValueCodec` is gone.
    - You now have to use `ZookeeperRegistrationSpec` and `ZookeeperDiscoverySpec` to encode and decode.
    - `ZooKeeperEndpointGroupBuilder.codec(...)` and `ZooKeeperUpatingListenerBuilder.codec(...)` are gone as well.

Result:
- You can now use Armeria client and server with Curator Service Discovery.
minwoox added a commit to minwoox/armeria that referenced this issue Jun 9, 2020
@minwoox
Support ServerSets service discovery
d20e378 
Motivation:
It will be nice if we support `ServerSets` service discovery.

Modifications:
- Add `ZooKeeperDiscoverySpec` and `ZooKeeperRegistrationSpec` for `ServerSets`
- Rename `...Zookeeper...` to `...ZooKeeper...` (K is capital letter.)

Result:
- Close line#2673
- You can now register an Armeria server and discover services with the `ServerSets` compatible format.
minwoox added a commit to minwoox/armeria that referenced this issue Jun 9, 2020
@minwoox
Support ServerSets service discovery
a3eb98c 
Motivation:
It will be nice if we support `ServerSets` service discovery.

Modifications:
- Add `ZooKeeperDiscoverySpec` and `ZooKeeperRegistrationSpec` for `ServerSets`
- Rename `...Zookeeper...` to `...ZooKeeper...` (K is capital letter.)

Result:
- Close line#2673
- You can now register an Armeria server and discover services with the `ServerSets` compatible format.
@minwoox minwoox mentioned this issue Jun 9, 2020
Merged
trustin pushed a commit that referenced this issue Jun 16, 2020
@minwoox
Support ServerSets service discovery (#2791)
78280bc 
Motivation:
It will be nice if we support `ServerSets` service discovery.

Modifications:
- Add `ZooKeeperDiscoverySpec` and `ZooKeeperRegistrationSpec` for `ServerSets`
- Rename `...Zookeeper...` to `...ZooKeeper...` (K is capital letter.)

Result:
- Close #2673
- You can now register an Armeria server and discover services with the `ServerSets` compatible format.
@trustin trustin modified the milestones: 1.0.0, 0.99.7 Jun 16, 2020
fmguerreiro pushed a commit to fmguerreiro/armeria that referenced this issue Sep 19, 2020
@minwoox
Support Curator Service Discovery and Spring Cloud ZooKeeper (line#2749)
79878e6 
Related: line#2673

Motivation:

It will be nice if we support Curator Service Discovery and Spring Cloud Zookeeper.

Modifications:
- Add `ZookeeperRegistrationSpec` and `ZookeeperDiscoverySpec` to specify whether use legacy format or Curator compatible format.
  - (Breaking) You should specify `ZookeeperRegistrationSpec` When creating `ZookeeperUpdatingListener`.
  - (Breaking) You should specify `ZookeeperDiscoverySpec` When creating `ZookeeperEndpointGroup`.
- (Breaking)
  - `NodeValueCodec` is gone.
    - You now have to use `ZookeeperRegistrationSpec` and `ZookeeperDiscoverySpec` to encode and decode.
    - `ZooKeeperEndpointGroupBuilder.codec(...)` and `ZooKeeperUpatingListenerBuilder.codec(...)` are gone as well.

Result:
- You can now use Armeria client and server with Curator Service Discovery.
fmguerreiro pushed a commit to fmguerreiro/armeria that referenced this issue Sep 19, 2020
@minwoox
Support ServerSets service discovery (line#2791)
3c84fe3 
Motivation:
It will be nice if we support `ServerSets` service discovery.

Modifications:
- Add `ZooKeeperDiscoverySpec` and `ZooKeeperRegistrationSpec` for `ServerSets`
- Rename `...Zookeeper...` to `...ZooKeeper...` (K is capital letter.)

Result:
- Close line#2673
- You can now register an Armeria server and discover services with the `ServerSets` compatible format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
0.99.7
Development

Successfully merging a pull request may close this issue.

Support ServerSets service discovery minwoox/armeria
2 participants
@trustin @minwoox