-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build.gradle.kts compatible documentation #4106
Labels
Milestone
Comments
Nice suggestion! It should be helpful to add armeria/site/src/components/required-dependencies.tsx Lines 95 to 99 in 1407871
Are you interested in sending a PR? 😄 |
Hi @ikhoon @tokuhirom, I've put up a PR (#4176) to address this issue, could you please help review it? |
Great! I’m happy to review it. |
ikhoon
pushed a commit
that referenced
this issue
Apr 11, 2022
Motivation: More users are starting to use Kotlin scripting, add this tab can help them copy-paste codes Modifications: - Add Gradle(Kotlin) tab to RequiredDependencies component Result: - Closes #4106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://armeria.dev/docs/client-retrofit/
Currently, armeria docs was written in this form.
It's a valid build.gradle groovy script.
But if the document is written in this form:
It's also compatible with build.gradle.kts(kotlin) script.
Recently, a lot of users are starting to use kotlin scripting.
I suggest to use this form(or display "Gradle", "Gradle(Kotlin)", "Maven" tabs at here)
The text was updated successfully, but these errors were encountered: