MatchesParam - Add new "OR" like syntax

[lucasamoroso]

Hi!

Given the following routes:

  @Get("/hello")
  @MatchesParam("with_status!=true")
  @MatchesParam("!with_status")
  def hello(): HttpResponse = HttpResponse.of(HttpStatus.OK, MediaType.PLAIN_TEXT, "Hello!")

  @Get("/hello")
  @MatchesParam("with_status=true")
  @MatchesParam("with_status")
  def helloWithStatus(): HttpResponse = HttpResponse.of(HttpStatus.OK, MediaType.PLAIN_TEXT, "Hello! My status is ok")

I'd like to call the helloWithStatus route in the following ways:

• curl http://localhost:8000/hello\?with_status\=true // This works
• curl http://localhost:8000/hello\?with_status // This doesn't work, returns a NOT_FOUND

The only way to make this work as expected is with the following code:

  @Get("/hello")
  @MatchesParam("with_status=false")
  def hello(): HttpResponse = HttpResponse.of(HttpStatus.OK, MediaType.PLAIN_TEXT, "Hello!")

  @Get("/hello")
  @MatchesParam("!with_status")
  def hello2(): HttpResponse = hello()

  @Get("/hello")
  @MatchesParam("with_status=true")
  def helloWithStatus(): HttpResponse = HttpResponse.of(HttpStatus.OK, MediaType.PLAIN_TEXT, "Hello! My status is ok")

  @Get("/hello")
  @MatchesParam("with_status")
  def helloWithStatus2() = helloWithStatus()

This seems to be because @MatchesParam is applying a logical AND.

So, with all that said, @trustin proposed a new syntax like @MatchesParam("with_status=true || with_status") to make my first example work. This is the the code that will use this new syntax.

  @Get("/hello")
  @MatchesParam("with_status!=true || !with_status")
  def hello(): HttpResponse = HttpResponse.of(HttpStatus.OK, MediaType.PLAIN_TEXT, "Hello!")

  @Get("/hello")
  @MatchesParam("with_status=true || with_status")
  def helloWithStatus(): HttpResponse = HttpResponse.of(HttpStatus.OK, MediaType.PLAIN_TEXT, "Hello! My status is ok")

And this should be the result:

• curl http://localhost:8000/hello\?with_status\=true // "Hello! My status is ok"
• curl http://localhost:8000/hello\?with_status // "Hello! My status is ok"
• curl http://localhost:8000/hello // "Hello!"
• curl http://localhost:8000/hello\?with_status\=false // "Hello!"

Can we add this new syntax?

[trustin]

Thanks a lot for the detailed description, @lucasamoroso. LGTM 👍