Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a way to configure a CacheSpec for HttpFileService #916

Closed
imasahiro opened this issue Dec 19, 2017 · 1 comment · Fixed by #2142
Closed

Provide a way to configure a CacheSpec for HttpFileService #916

imasahiro opened this issue Dec 19, 2017 · 1 comment · Fixed by #2142
Labels
improvement
Milestone
0.95.0

Comments

@imasahiro
Copy link
Member

Currently, there is no way to configure a cache for DocService instantiated by ArmeriaAutoConfiguration#armeriaServer.

To make it more configurable, it is better to provide a new flag to Flags (or ArmeriaSettings).
@trustin trustin changed the title Provides a way to configure a CacheSpec for HttpFileService Provide a way to configure a CacheSpec for HttpFileService Dec 21, 2017
imasahiro added a commit to imasahiro/armeria that referenced this issue Dec 22, 2017
@imasahiro
Add a way to Configure cache spec for HttpFileService
803e4c1 
Fixes line#916
@heowc
Copy link
Contributor

heowc commented Oct 2, 2019

I'll work on it!

@heowc heowc mentioned this issue Oct 2, 2019
Merged
trustin pushed a commit that referenced this issue Oct 10, 2019
@heowc @trustin
Provide a way to configure a CacheSpec for HttpFileService (#2142)
84d3b36 
Motivation:

A user cannot set a way to configure a CacheSpec for HttpFileService.

Modifications:

- Add a new flag `com.linecorp.armeria.fileServiceCache=<spec>`
- Add `entryCacheSpec` for `HttpFileServiceBuilder`
- Delegate `maxCacheEntries` to `entryCacheSpec`

Result:

- Fixes #916
@trustin trustin added this to the 0.95.0 milestone Oct 10, 2019
eugene70 pushed a commit to eugene70/armeria that referenced this issue Oct 16, 2019
@heowc
Provide a way to configure a CacheSpec for HttpFileService (line#2142)
bf60a88 
Motivation:

A user cannot set a way to configure a CacheSpec for HttpFileService.

Modifications:

- Add a new flag `com.linecorp.armeria.fileServiceCache=<spec>`
- Add `entryCacheSpec` for `HttpFileServiceBuilder`
- Delegate `maxCacheEntries` to `entryCacheSpec`

Result:

- Fixes line#916
fmguerreiro pushed a commit to fmguerreiro/armeria that referenced this issue Sep 19, 2020
@heowc @trustin
Provide a way to configure a CacheSpec for HttpFileService (line#2142)
031878d 
Motivation:

A user cannot set a way to configure a CacheSpec for HttpFileService.

Modifications:

- Add a new flag `com.linecorp.armeria.fileServiceCache=<spec>`
- Add `entryCacheSpec` for `HttpFileServiceBuilder`
- Delegate `maxCacheEntries` to `entryCacheSpec`

Result:

- Fixes line#916
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
0.95.0
Development

Successfully merging a pull request may close this issue.

Provide a way to configure a CacheSpec for HttpFileService heowc/armeria
3 participants
@imasahiro @trustin @heowc