Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS #1098

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Add CODEOWNERS #1098

merged 1 commit into from
Mar 16, 2018

Conversation

anuraaga
Copy link
Collaborator

Currently, contributors have to search through a longish list of reviewers for the three main maintainers when requesting reviews. With a CODEOWNERS file, the maintainers will be automatically added to PRs as reviewers.

It is also possible to add directory-specific owners, which I went ahead and did for gRPC.

@codecov
Copy link

codecov bot commented Mar 16, 2018

Codecov Report

Merging #1098 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1098      +/-   ##
==========================================
- Coverage   72.39%   72.27%   -0.12%     
==========================================
  Files         507      507              
  Lines       22377    22377              
  Branches     2772     2772              
==========================================
- Hits        16199    16174      -25     
- Misses       4703     4729      +26     
+ Partials     1475     1474       -1
Impacted Files Coverage Δ
...armeria/server/tomcat/Tomcat85ProtocolHandler.java 50% <0%> (-13.64%) ⬇️
.../linecorp/armeria/server/tomcat/TomcatService.java 59.32% <0%> (-7.63%) ⬇️
...meria/common/stream/RegularFixedStreamMessage.java 82.97% <0%> (-6.39%) ⬇️
...linecorp/armeria/internal/Http2GoAwayListener.java 76% <0%> (-4%) ⬇️
...inecorp/armeria/client/grpc/ArmeriaClientCall.java 76.92% <0%> (-1.71%) ⬇️
...com/linecorp/armeria/internal/grpc/GrpcStatus.java 44.44% <0%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6859257...d9b4a19. Read the comment docs.

Copy link
Member

@trustin trustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks!

@minwoox
Copy link
Member

minwoox commented Mar 16, 2018

Awesome!

@minwoox minwoox merged commit ee812d8 into line:master Mar 16, 2018
@minwoox
Copy link
Member

minwoox commented Mar 16, 2018

Thanks @anuraaga

fmguerreiro pushed a commit to fmguerreiro/armeria that referenced this pull request Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants