Add client and service decorators to track requests using Dropwizard … #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain more about why implemented new one instead of using |
| Timer.Context timer = metrics.time(); | ||
| promise.addListener(future -> { | ||
| timer.stop(); | ||
| if (future.isSuccess()) { |
There was a problem hiding this comment.
don't we need to check its status code? i.e. is it successful even if future is 500 or so?
| * <p>It is generally recommended to define your own name for the service instead of using something like | ||
| * the Java class to make sure otherwise safe changes like renames don't break metrics.</p> | ||
| */ | ||
| public static Function<Client, Client> newDropwizardMetricsDecorator( |
There was a problem hiding this comment.
Went with newDropwizardDecorator, but in practice maybe there won't be any other implementations.
|
Updated |
|
We have two Javadoc errors: |
| * .build(MyService.Iface.class); | ||
| * } | ||
| * </pre> | ||
| * </p> |
There was a problem hiding this comment.
No Idea why, but Javadoc still complains. Could you fix this?
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project armeria: Error generating maven-javadoc-plugin:2.10.3:javadoc:
[ERROR] Exit code: 1 - /home/travis/build/line/armeria/src/main/java/com/linecorp/armeria/client/metrics/MetricCollectingClient.java:25: error: unexpected end tag: </p>
[ERROR] * </p>
[ERROR] ^
[ERROR] /home/travis/build/line/armeria/src/main/java/com/linecorp/armeria/server/metrics/MetricCollectingService.java:45: error: unexpected end tag: </p>
[ERROR] * </p>
[ERROR] ^
|
LGTM 👍 |
trustin
added a commit
that referenced
this pull request
Feb 24, 2016
Add client and service decorators to track requests using Dropwizard …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…metrics.