Make EventLoop available to RemoteInvoker.invoke() #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: EventLoop to perform the actual invocation is determined at the HttpRemoteInvoker.invoke() method, which is the last moment right before the invocation. It means decorating RemoteInvokers does not have an access to the EventLoop, nevertheless the EventLoop can be determined from the beginning of the invocation. A decorating RemoteInvoker with an access to an EventLoop could create Future/Promise and schedule a task, which will be useful when building an advanced decorator such as a circuit breaker. Modifications: - Add EventLoop parameter to RemoteInvoker.invoke() - Determine the EventLoop to perform the invocation in ClientInvocationHandler instead of in HttpRemoteInvoker - Move HttpRemoteInvoker.eventLoop() to ClientInvocationHandler - Reorder the methods in HttpRemoteInvoker for readability Result: A decorating RemoteInvoker now has an access to the EventLoop which will perform the actual invocation.
| return ServiceInvocationContext.mapCurrent(ServiceInvocationContext::eventLoop, eventLoopGroup::next); | ||
| private KeyedChannelPool<PoolKey> pool(EventLoop eventLoop) { | ||
| KeyedChannelPool<PoolKey> pool = map.get(eventLoop); | ||
| if (pool != null) { |
There was a problem hiding this comment.
just a question, why is this needed? computeIfAbsent should return immediately if present
There was a problem hiding this comment.
Probably to avoid the instantiation of the Function that's given as the second argument?
|
LGTM |
synk
added a commit
that referenced
this pull request
Mar 7, 2016
Make EventLoop available to RemoteInvoker.invoke()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
EventLoop to perform the actual invocation is determined at the
HttpRemoteInvoker.invoke() method, which is the last moment right before
the invocation.
It means decorating RemoteInvokers does not have an access to the
EventLoop, nevertheless the EventLoop can be determined from the
beginning of the invocation.
A decorating RemoteInvoker with an access to an EventLoop could create
Future/Promise and schedule a task, which will be useful when building
an advanced decorator such as a circuit breaker.
Modifications:
ClientInvocationHandler instead of in HttpRemoteInvoker
Result:
A decorating RemoteInvoker now has an access to the EventLoop which will
perform the actual invocation.