Allow registering callbacks when propagating a ServiceInvocationConte… #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @synk |
| } | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| private static void resetContext(ServiceInvocationContext ctx) { | ||
| removeCurrent(); | ||
| ctx.makeContextAwareHandlers.forEach(MakeContextAwareHandler::exit); |
There was a problem hiding this comment.
makeContextAwareHandlers seems nullable?
There was a problem hiding this comment.
Thanks - added test too.
| return true; | ||
| }); | ||
| } | ||
|
|
||
| public void addMakeContextAwareHandler(Runnable onContextEnter, Runnable onContextExit) { | ||
| if (makeContextAwareHandlers == null) { | ||
| makeContextAwareHandlers = new ArrayList<>(); |
|
Updated to use two lists |
…xt and set them for tracing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…xt and set them for tracing.
In fully asynchronous servers, it is common to jump in and out of the execution thread, and we need to restore ThreadLocal state every time this happens. We have the makeContextAware family of methods to restore ServiceInvocationContext, but for tracing we also need to restore the ServerSpan.