Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #1280

Merged
merged 1 commit into from
Jul 11, 2018
Merged

Update dependencies #1280

merged 1 commit into from
Jul 11, 2018

Conversation

trustin
Copy link
Member

@trustin trustin commented Jul 11, 2018

  • Netty 4.1.25 -> 4.1.26
    • Netty TCNative BoringSSL 2.0.10 -> 2.0.12
  • Bouncy Castle 1.59 -> 1.60
  • Tomcat 8.0.52 -> 8.0.53
  • Build-time only dependencies
    • Apache HttpComponents 4.5.5 -> 4.5.6
    • Awaitility 3.1.0 -> 3.1.1
    • Checker framework 2.5.2 -> 2.5.3
    • Checkstyle 8.10.1 -> 8.11

@trustin
Update dependencies
63594b8 
- Netty 4.1.25 -> 4.1.26
  - Netty TCNative BoringSSL 2.0.10 -> 2.0.12
- Bouncy Castle 1.59 -> 1.60
- Tomcat 8.0.52 -> 8.0.53
- Build-time only dependencies
  - Apache HttpComponents 4.5.5 -> 4.5.6
  - Awaitility 3.1.0 -> 3.1.1
  - Checker framework 2.5.2 -> 2.5.3
  - Checkstyle 8.10.1 -> 8.11
@trustin trustin added this to the 0.68.0 milestone Jul 11, 2018
@trustin trustin requested a review from anuraaga July 11, 2018 02:56
anuraaga
anuraaga approved these changes Jul 11, 2018
View reviewed changes
dependencies.yml
@@ -132,7 +132,7 @@ io.micrometer:
- org.springframework:spring-webmvc

io.netty:
netty-codec-http2: { version: &NETTY_VERSION '4.1.25.Final' }
netty-codec-http2: { version: &NETTY_VERSION '4.1.26.Final' }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah was the problem just incompatibility with Netty itself?

Copy link
Member Author

@trustin trustin Jul 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it seems so. Like using wrong version of protoc with gRPC :-)

@codecov
Copy link

codecov bot commented Jul 11, 2018

Codecov Report

Merging #1280 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1280      +/-   ##
==========================================
- Coverage   72.59%   72.58%   -0.01%     
==========================================
  Files         557      557              
  Lines       24159    24159              
  Branches     2947     2947              
==========================================
- Hits        17538    17537       -1     
- Misses       5074     5075       +1     
  Partials     1547     1547
Impacted Files Coverage Δ
...m/linecorp/armeria/internal/HttpObjectEncoder.java 58.33% <0%> (-8.34%) ⬇️
...linecorp/armeria/client/HttpRequestSubscriber.java 68.09% <0%> (-0.62%) ⬇️
...corp/armeria/common/logging/DefaultRequestLog.java 80.8% <0%> (-0.26%) ⬇️
...inecorp/armeria/client/grpc/ArmeriaClientCall.java 79.66% <0%> (+1.69%) ⬆️
...necorp/armeria/server/GracefulShutdownSupport.java 97.29% <0%> (+2.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63310c1...63594b8. Read the comment docs.

@trustin trustin merged commit 1fa610e into line:master Jul 11, 2018
@trustin trustin deleted the update_deps branch July 11, 2018 05:42
fmguerreiro pushed a commit to fmguerreiro/armeria that referenced this pull request Sep 19, 2020
@trustin
Update dependencies (line#1280)
6e5199b 
- Netty 4.1.25 -> 4.1.26
  - Netty TCNative BoringSSL 2.0.10 -> 2.0.12
- Bouncy Castle 1.59 -> 1.60
- Tomcat 8.0.52 -> 8.0.53
- Build-time only dependencies
  - Apache HttpComponents 4.5.5 -> 4.5.6
  - Awaitility 3.1.0 -> 3.1.1
  - Checker framework 2.5.2 -> 2.5.3
  - Checkstyle 8.10.1 -> 8.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@hyangtack hyangtack hyangtack approved these changes

@minwoox minwoox minwoox approved these changes

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
0.67.2
Development

Successfully merging this pull request may close these issues.
4 participants
@trustin @anuraaga @hyangtack @minwoox