circuit breaker metrics tracking #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synk
force-pushed
the
develop-circuitbreaker-monitor
branch
2 times, most recently
from
5ea93ac
to
0273698
Compare
synk
force-pushed
the
develop-circuitbreaker-monitor
branch
2 times, most recently
from
ec3aadc
to
fbbc9a1
Compare
| @@ -223,7 +240,7 @@ public CircuitBreaker build() { | |||
| new CircuitBreakerConfig(name, failureRateThreshold, minimumRequestThreshold, | |||
| circuitOpenWindow, trialRequestInterval, | |||
| counterSlidingWindow, counterUpdateInterval, | |||
| exceptionFilter)); | |||
| exceptionFilter, listeners)); | |||
There was a problem hiding this comment.
Wrap with Collections.unmodifiableList()?
synk
force-pushed
the
develop-circuitbreaker-monitor
branch
2 times, most recently
from
8dcab5b
to
f1fdb7e
Compare
| /** | ||
| * Invoked when the circuit state is changed. | ||
| */ | ||
| void onStateChanged(CircuitBreaker circuitBreaker, CircuitState state); |
There was a problem hiding this comment.
How about adding throws Exception to all listener methods so that a user doesn't need to catch boring checked exceptions?
There was a problem hiding this comment.
Because CircuitBreakerListener will be called from the core of the circuit breaker directly, That should be carefully implemented. IMO, It would be better that listeners handle the exceptions by them self.
But It is reasonable to add the throws to be consistent with armeria's policy!
There was a problem hiding this comment.
There's always a chance of throwing a RuntimeException regardless we added throws Exception or not. :-)
synk
force-pushed
the
develop-circuitbreaker-monitor
branch
from
f1fdb7e
to
9dd89e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
CircuitBreakerListenerinterface to track circuit breaker stats.CircuitStateandEventCountpublic to use fromCircuitBreakerListenerdefinition.