Revamp connection pool #1441
Merged
Revamp connection pool #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1441 +/- ##
==========================================
+ Coverage 72.75% 72.88% +0.13%
==========================================
Files 617 613 -4
Lines 26842 26750 -92
Branches 3246 3248 +2
==========================================
- Hits 19528 19496 -32
+ Misses 5599 5543 -56
+ Partials 1715 1711 -4
Continue to review full report at Codecov.
|
hyangtack
reviewed
Nov 15, 2018
core/src/main/java/com/linecorp/armeria/client/HttpChannelPool.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/client/SafeConnectionPoolListener.java
Outdated
Show resolved
Hide resolved
hyangtack
reviewed
Nov 15, 2018
core/src/main/java/com/linecorp/armeria/client/HttpClientDelegate.java
Outdated
Show resolved
Hide resolved
anuraaga
reviewed
Nov 15, 2018
core/src/main/java/com/linecorp/armeria/client/ConnectionPoolListenerAdapter.java
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/client/HttpChannelPool.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/client/HttpChannelPool.java
Outdated
Show resolved
Hide resolved
minwoox
reviewed
Nov 15, 2018
core/src/main/java/com/linecorp/armeria/client/HttpClientDelegate.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/client/HttpSessionHandler.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/client/SafeConnectionPoolListener.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/client/logging/ConnectionPoolLoggingListener.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/client/logging/ConnectionPoolLoggingListener.java
Outdated
Show resolved
Hide resolved
minwoox
reviewed
Nov 15, 2018
core/src/main/java/com/linecorp/armeria/client/HttpChannelPool.java
Outdated
Show resolved
Hide resolved
|
@inch772 You might want to review this pull request since 1) the connection pooling has been written by you initially and 2) you might be looking for a chance to exercise your coding skill! |
minwoox
approved these changes
Nov 16, 2018
core/src/main/java/com/linecorp/armeria/client/HttpChannelPool.java
Outdated
Show resolved
Hide resolved
anuraaga
approved these changes
Nov 16, 2018
core/src/main/java/com/linecorp/armeria/client/ConnectionPoolListenerAdapter.java
Show resolved
Hide resolved
|
LGTM again~! |
|
LGTM |
Related: line#818 Motivation: - Unlike HTTP/1 connections, HTTP/2 connections do not need to be removed from the connection pool. We has slight loss of efficiency because we currently remove an HTTP/2 connection from the pool and add it back. - Current connection pool implementation has unnecessarily deep type hierarchy and high level of indirection which weren't very useful. - There's circular package dependency between `armeria.client` and `armeria.client.pool` which is undesirable. Modifications: - Merged `HttpSessionChannelFactory`, `KeyedChannelPool` and `DefaultKeyedChannelPool` into `HttpChannelPool`. - Tuned the internal data structure of `DefaultKeyedChannelPool`. - `PoolKey` does not include `SessionProtocol` anymore. We keep separate `Map` for each `SessionProtocol`. - Improved the connection pool implementation so that the connections with the same session protocol are grouped together even if they were created from different URI schemes. For example, both `h2c://` and `http://` can create `h2c` connections, but their connections were treated differently, but not anymore. - Removed unnecessary synchronization since all code in `HttpChannelPool` should be run in an event loop. - Replaced `KeyedChannelPoolHandler` and its related classes with `ConnectionPoolListener` et al. - We do not notify the listeners about acquisition and release because it has no meaning for HTTP/2 and it is more meaningful to retrieve such information from `RequestLog`. Let me know if you have a suggestions for more listener methods. Result: - Fixes line#818 - Connection pool listener API has a breaking change.
|
Thank you, reviewers! |
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
Related: line#818 Motivation: - Unlike HTTP/1 connections, HTTP/2 connections do not need to be removed from the connection pool. We has slight loss of efficiency because we currently remove an HTTP/2 connection from the pool and add it back. - Current connection pool implementation has unnecessarily deep type hierarchy and high level of indirection which weren't very useful. - There's circular package dependency between `armeria.client` and `armeria.client.pool` which is undesirable. Modifications: - Merged `HttpSessionChannelFactory`, `KeyedChannelPool` and `DefaultKeyedChannelPool` into `HttpChannelPool`. - Tuned the internal data structure of `DefaultKeyedChannelPool`. - `PoolKey` does not include `SessionProtocol` anymore. We keep separate `Map` for each `SessionProtocol`. - Improved the connection pool implementation so that the connections with the same session protocol are grouped together even if they were created from different URI schemes. For example, both `h2c://` and `http://` can create `h2c` connections, but their connections were treated differently, but not anymore. - Removed unnecessary synchronization since all code in `HttpChannelPool` should be run in an event loop. - Replaced `KeyedChannelPoolHandler` and its related classes with `ConnectionPoolListener` et al. - We do not notify the listeners about acquisition and release because it has no meaning for HTTP/2 and it is more meaningful to retrieve such information from `RequestLog`. Let me know if you have a suggestions for more listener methods. Result: - Fixes line#818 - Connection pool listener API has a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #818
Motivation:
removed from the connection pool. We has slight loss of efficiency
because we currently remove an HTTP/2 connection from the pool and
add it back.
hierarchy and high level of indirection which weren't very useful.
armeria.clientandarmeria.client.poolwhich is undesirable.Modifications:
HttpSessionChannelFactory,KeyedChannelPoolandDefaultKeyedChannelPoolintoHttpChannelPool.DefaultKeyedChannelPool.PoolKeydoes not includeSessionProtocolanymore. We keepseparate
Mapfor eachSessionProtocol.with the same session protocol are grouped together even if they
were created from different URI schemes. For example, both
h2c://and
http://can createh2cconnections, but their connectionswere treated differently, but not anymore.
HttpChannelPoolshould be run in an event loop.KeyedChannelPoolHandlerand its related classes withConnectionPoolListeneret al.it has no meaning for HTTP/2 and it is more meaningful to retrieve
such information from
RequestLog. Let me know if you have asuggestions for more listener methods.
Result: