Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more debug information to HTTP/2 GOAWAY frame #145

Merged
merged 1 commit into from
Apr 19, 2016

Conversation

trustin
Copy link
Member

@trustin trustin commented Apr 18, 2016

Motivation:

An HTTP/2 GOAWAY frame with non-zero error code sometimes gives an empty
debugData, making it hard to determine the root cause of the error.

Modifications:

  • Add the following information to debugData:
    • the exact type of Http2Exception
    • the original message of Http2Exception
    • the exact type, message and stack trace of the cause of Http2Exception
  • Add Exceptions.traceText() to stringify the stack trace of an
    exception
  • Fix incorrect Logger level check

Result:

We will have more information when we get an error GOAWAY frame.

@@ -59,9 +66,44 @@ protected void onConnectionError(ChannelHandlerContext ctx, Throwable cause, Htt
}

handlingConnectionError = true;

// TODO(trustin): Remove this once Http2ConnectionHandler.goAway() sends better debugData.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any upstream issue to reference?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Will add a link.

Motivation:

An HTTP/2 GOAWAY frame with non-zero error code sometimes gives an empty
debugData, making it hard to determine the root cause of the error.

Modifications:

- Add the following information to debugData:
  - the exact type of Http2Exception
  - the original message of Http2Exception
  - the exact type, message and stack trace of the cause of Http2Exception
- Add Exceptions.traceText() to stringify the stack trace of an
  exception
- Fix incorrect Logger level check

Result:

We will have more information when we get an error GOAWAY frame.
@anuraaga anuraaga merged commit 88e976b into line:master Apr 19, 2016
@trustin trustin deleted the more_http2_goaway_debug branch April 19, 2016 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants