Make sure listeners are notified after first health check has resolved. #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -106,7 +113,7 @@ protected final void setEndpoints(Iterable<Endpoint> endpoints) { | |||
| } | |||
|
|
|||
| private void completeInitialEndpointsFuture(List<Endpoint> endpoints) { | |||
| if (!endpoints.isEmpty() && !initialEndpointsFuture.isDone()) { | |||
codefromthecrypt
approved these changes
Sep 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #2074 +/- ##
============================================
- Coverage 73.8% 73.66% -0.14%
+ Complexity 9392 9373 -19
============================================
Files 817 817
Lines 36121 36125 +4
Branches 4452 4452
============================================
- Hits 26658 26611 -47
- Misses 7155 7211 +56
+ Partials 2308 2303 -5
Continue to review full report at Codecov.
|
minwoox
approved these changes
Sep 16, 2019
core/src/main/java/com/linecorp/armeria/client/endpoint/DynamicEndpointGroup.java
Show resolved
Hide resolved
trustin
approved these changes
Sep 16, 2019
|
Thanks, @ikhoon ! |
|
Oops. Thanks, @anuraaga ! |
eugene70
pushed a commit
to eugene70/armeria
that referenced
this pull request
Oct 16, 2019
…d. (line#2074) Currently if all endpoints start out unhealthy, then the initial endpoints future for a health checked endpoint group never completes. The initial endpoints future should indicate when the endpoints have first been checked, not when they first become healthy - while an `EndpointGroup` with no `Endpoint`s is sort of useless, I think it's still a perfectly good `EndpointGroup` and deserves notifying listeners :)
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
…d. (line#2074) Currently if all endpoints start out unhealthy, then the initial endpoints future for a health checked endpoint group never completes. The initial endpoints future should indicate when the endpoints have first been checked, not when they first become healthy - while an `EndpointGroup` with no `Endpoint`s is sort of useless, I think it's still a perfectly good `EndpointGroup` and deserves notifying listeners :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if all endpoints start out unhealthy, then the initial endpoints future for a health checked endpoint group never completes. The initial endpoints future should indicate when the endpoints have first been checked, not when they first become healthy - while an
EndpointGroupwith noEndpoints is sort of useless, I think it's still a perfectly goodEndpointGroupand deserves notifying listeners :)/cc @adriancole