Deletes code no longer needed regarding state checking of ES hosts #2800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer need two-tiered checking of ES addresses because single endpoint is special cased to not cause notable overhead. See line/armeria#2071 (comment)
anuraaga
reviewed
Sep 13, 2019
zipkin-server/src/main/java/zipkin2/server/internal/elasticsearch/LazyHttpClientImpl.java
Outdated
Show resolved
Hide resolved
anuraaga
approved these changes
Sep 13, 2019
|
@anuraaga I added a commit as we weren't looking for empty results before. This should make the change compatible with line/armeria#2074 |
|
Thanks @anuraaga! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need two-tiered checking of ES addresses because single
endpoint is special cased to not cause notable overhead.
See line/armeria#2071 (comment)