Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE in Http1ClientCodec #2210

Merged
merged 2 commits into from
Oct 24, 2019
Merged

Fix NPE in Http1ClientCodec #2210

merged 2 commits into from
Oct 24, 2019

Commits on Oct 24, 2019

  1. Fix NPE in Http1ClientCodec 

    Motivation:
If the remote peer sends multiple responses for one request, which is not allowed by the spec but may still be possible,
NPE can be raised in `Http1ClientCodec`.

Modification:
- Copy `Http1ClientCodec` from the upstream Netty 4.1.42 at 39cc7a673939dec96258ff27f5b1874671838af0

Result:
- No more NPE in `Http1ClientCodec`
    @minwoox
    minwoox committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    1e492d7 View commit details
    Browse the repository at this point in the history

  2. Remove if condition

    @minwoox
    minwoox committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    6d29c1f View commit details
    Browse the repository at this point in the history