-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NPE in Http1ClientCodec #2210
Conversation
Motivation: If the remote peer sends multiple responses for one request, which is not allowed by the spec but may still be possible, NPE can be raised in `Http1ClientCodec`. Modification: - Copy `Http1ClientCodec` from the upstream Netty 4.1.42 at 39cc7a673939dec96258ff27f5b1874671838af0 Result: - No more NPE in `Http1ClientCodec`
Related: netty/netty#9465 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @minwoox !
Codecov Report
@@ Coverage Diff @@
## master #2210 +/- ##
============================================
- Coverage 73.66% 73.64% -0.03%
- Complexity 9610 9614 +4
============================================
Files 839 839
Lines 37000 37001 +1
Branches 4557 4558 +1
============================================
- Hits 27256 27249 -7
- Misses 7418 7427 +9
+ Partials 2326 2325 -1
Continue to review full report at Codecov.
|
Thanks for reviewing! |
Motivation: HTTP 102 (WebDAV) is not correctly treated as an informational response Modification: Delegate all `1XX` status codes to superclass, not just `100` and `101`. Result: Supports WebDAV response. Removes a huge maintenance [headache](line/armeria#2210) in Armeria which has forked the class for these features
Motivation: HTTP 102 (WebDAV) is not correctly treated as an informational response Modification: Delegate all `1XX` status codes to superclass, not just `100` and `101`. Result: Supports WebDAV response. Removes a huge maintenance [headache](line/armeria#2210) in Armeria which has forked the class for these features
* Fix NPE in Http1ClientCodec Motivation: If the remote peer sends multiple responses for one request, which is not allowed by the spec but may still be possible, NPE can be raised in `Http1ClientCodec`. Modification: - Copy `Http1ClientCodec` from the upstream Netty 4.1.42 at 39cc7a673939dec96258ff27f5b1874671838af0 Result: - No more NPE in `Http1ClientCodec`
* Fix NPE in Http1ClientCodec Motivation: If the remote peer sends multiple responses for one request, which is not allowed by the spec but may still be possible, NPE can be raised in `Http1ClientCodec`. Modification: - Copy `Http1ClientCodec` from the upstream Netty 4.1.42 at 39cc7a673939dec96258ff27f5b1874671838af0 Result: - No more NPE in `Http1ClientCodec`
Motivation:
If the remote peer sends multiple responses for one request, which is not allowed by the spec but may still be possible,
NPE can be raised in
Http1ClientCodec
.Modification:
Http1ClientCodec
from the upstream Netty 4.1.42 at 39cc7a673939dec96258ff27f5b1874671838af0Result:
Http1ClientCodec