Switch to static builder() methods
#2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trustin
commented
Oct 30, 2019
Comment on lines
64
to
67
| ClientFactory DEFAULT = new ClientFactoryBuilder().build(); | ||
| ClientFactory DEFAULT = builder().build(); |
There was a problem hiding this comment.
Should we switch to ofDefault()?
There was a problem hiding this comment.
+1 I would lean towards using ofDefaults()
There was a problem hiding this comment.
OK. Let me take care of it in another pull request.
|
While working on this, I found the following builder classes do not match well with the new pattern:
|
jyblue
reviewed
Oct 30, 2019
...rc/main/java/com/linecorp/armeria/client/retrofit2/RetrofitMeterIdPrefixFunctionBuilder.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2221 +/- ##
============================================
+ Coverage 73.52% 73.55% +0.02%
- Complexity 9720 9749 +29
============================================
Files 848 849 +1
Lines 37535 37555 +20
Branches 4610 4610
============================================
+ Hits 27599 27624 +25
+ Misses 7575 7568 -7
- Partials 2361 2363 +2
Continue to review full report at Codecov.
|
|
+1 for
Retrofit is a final class so we cannot extend it. I'm not sure which one is the best. 😢 |
|
Gentle ping, guys 😆 |
|
Took advantage of review lag to migrate more builders. 😝 |
|
Note to self: Use |
anuraaga
approved these changes
Nov 3, 2019
core/src/main/java/com/linecorp/armeria/client/ClientOptions.java
Outdated
Show resolved
Hide resolved
minwoox
approved these changes
Nov 4, 2019
ikhoon
approved these changes
Nov 4, 2019
core/src/main/java/com/linecorp/armeria/client/ClientRequestContext.java
Outdated
Show resolved
Hide resolved
trustin
force-pushed
the
builders
branch
2 times, most recently
from
6d61a55
to
92aa64b
Compare
Related: line#1719 Motivation: We decided to switch from `new *Builder()` to `*.builder()`. Modifications: - Switch to static `builder()` methods in: - `ClientFactory` - `ClientOptions` - `ClientDecoration` - `ClientConnectionTimings` - `HttpClient` - `LoggingClient` - `LoggingService` - `EndpointInfo` - `FieldInfo` - `ClientCacheControl` - `ServerCacheControl` - `ClientRequestContext` - `ServiceRequestContext` - `RequestContextCurrentTraceContext` - `RetrofitMeterIdPrefixFunction` - (Breaking) `RetrofitMeterIfPrefixFunctionBuilder` is now a top-level class without a public constructor. - Miscellaneous: - Increase the test timeout for `ArmeriaSpringActuatorAutoConfigurationTest` for less flakiness - Maybe fixes the flakiness in `GracefulShutdownSupportTest`
|
Sneaking in two miscellaneous changes, but I guess it's OK. Will merge tomorrow morning. Leave a message if you'd like them as a separate PR. |
eugene70
pushed a commit
to eugene70/armeria
that referenced
this pull request
Nov 10, 2019
Related: line#1719 Motivation: We decided to switch from `new *Builder()` to `*.builder()`. Modifications: - Switch to static `builder()` methods in: - `ClientFactory` - `ClientOptions` - `ClientDecoration` - `ClientConnectionTimings` - `HttpClient` - `LoggingClient` - `LoggingService` - `EndpointInfo` - `FieldInfo` - `ClientCacheControl` - `ServerCacheControl` - `ClientRequestContext` - `ServiceRequestContext` - `RequestContextCurrentTraceContext` - `RetrofitMeterIdPrefixFunction` - (Breaking) `RetrofitMeterIfPrefixFunctionBuilder` is now a top-level class without a public constructor. - Miscellaneous: - Increase the test timeout for `ArmeriaSpringActuatorAutoConfigurationTest` for less flakiness - Maybe fixes the flakiness in `GracefulShutdownSupportTest`
trustin
pushed a commit
that referenced
this pull request
Dec 30, 2019
Related: #2221 * Makes user to use ServerListener.builder() to get ServerListenerBuilder * Makes user to use SimpleCompositeService.builder() to get SimplecompositeServiceBuilder * Makes user to use SimpleCompositeRpcService.builder() to get SimplecompositeRpcServiceBuilder * Makes user to use CorsPolicy.builder() to get CorsPolicyBuilder * Makes user to use DocService.builder() to get DocServiceBuilder * Makes user to use LoggingService.builder() to get LoggingServiceBuilder * Makes user to use JettyService.builder() to get JettyServiceBuilder * Makes user to use SamlServiceProvider.builder() to get SamlServiceProviderBuilder * Makes user to use ZooKeeperUpdatingListener.builder() to get ZooKeeperUpdatingListenerBuilder
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
Related: line#1719 Motivation: We decided to switch from `new *Builder()` to `*.builder()`. Modifications: - Switch to static `builder()` methods in: - `ClientFactory` - `ClientOptions` - `ClientDecoration` - `ClientConnectionTimings` - `HttpClient` - `LoggingClient` - `LoggingService` - `EndpointInfo` - `FieldInfo` - `ClientCacheControl` - `ServerCacheControl` - `ClientRequestContext` - `ServiceRequestContext` - `RequestContextCurrentTraceContext` - `RetrofitMeterIdPrefixFunction` - (Breaking) `RetrofitMeterIfPrefixFunctionBuilder` is now a top-level class without a public constructor. - Miscellaneous: - Increase the test timeout for `ArmeriaSpringActuatorAutoConfigurationTest` for less flakiness - Maybe fixes the flakiness in `GracefulShutdownSupportTest`
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
) Related: line#2221 * Makes user to use ServerListener.builder() to get ServerListenerBuilder * Makes user to use SimpleCompositeService.builder() to get SimplecompositeServiceBuilder * Makes user to use SimpleCompositeRpcService.builder() to get SimplecompositeRpcServiceBuilder * Makes user to use CorsPolicy.builder() to get CorsPolicyBuilder * Makes user to use DocService.builder() to get DocServiceBuilder * Makes user to use LoggingService.builder() to get LoggingServiceBuilder * Makes user to use JettyService.builder() to get JettyServiceBuilder * Makes user to use SamlServiceProvider.builder() to get SamlServiceProviderBuilder * Makes user to use ZooKeeperUpdatingListener.builder() to get ZooKeeperUpdatingListenerBuilder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1719
Motivation:
We decided to switch from
new *Builder()to*.builder().Modifications:
builder()methods in:ClientFactoryClientOptionsClientDecorationClientConnectionTimingsHttpClientLoggingClientLoggingServiceEndpointInfoFieldInfoClientCacheControlServerCacheControlClientRequestContextServiceRequestContextRequestContextCurrentTraceContextRetrofitMeterIdPrefixFunctionRetrofitMeterIfPrefixFunctionBuilderis now a top-level class without a public constructor.ArmeriaSpringActuatorAutoConfigurationTestfor less flakinessGracefulShutdownSupportTest