Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to static builder() methods #2221

Merged
merged 1 commit into from Nov 5, 2019
Merged

Switch to static builder() methods #2221

merged 1 commit into from Nov 5, 2019

Commits on Nov 4, 2019

  1. Switch to static builder() methods

    Related: line#1719
    Motivation:
    
    We decided to switch from `new *Builder()` to `*.builder()`.
    
    Modifications:
    
    - Switch to static `builder()` methods in:
      - `ClientFactory`
      - `ClientOptions`
      - `ClientDecoration`
      - `ClientConnectionTimings`
      - `HttpClient`
      - `LoggingClient`
      - `LoggingService`
      - `EndpointInfo`
      - `FieldInfo`
      - `ClientCacheControl`
      - `ServerCacheControl`
      - `ClientRequestContext`
      - `ServiceRequestContext`
      - `RequestContextCurrentTraceContext`
      - `RetrofitMeterIdPrefixFunction`
        - (Breaking) `RetrofitMeterIfPrefixFunctionBuilder` is now a top-level class without a public constructor.
    - Miscellaneous:
      - Increase the test timeout for `ArmeriaSpringActuatorAutoConfigurationTest` for less flakiness
      - Maybe fixes the flakiness in `GracefulShutdownSupportTest`
    trustin committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    68cc53e View commit details
    Browse the repository at this point in the history