Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute grpc-timeout header after processing grpc deadline instead of… #2643

Merged
merged 3 commits into from
Apr 2, 2020
Merged

Compute grpc-timeout header after processing grpc deadline instead of… #2643

merged 3 commits into from
Apr 2, 2020

Conversation

anuraaga
Copy link
Collaborator

@anuraaga anuraaga commented Mar 31, 2020 •
edited
Loading

… before

@minwoox
Copy link
Member

minwoox commented Mar 31, 2020

Could you check the test failure? https://ci.appveyor.com/project/line/armeria/builds/31841868/job/p3wlugyyj7rkodxy#L1136

@minwoox minwoox added the defect label Mar 31, 2020
@minwoox minwoox added this to the 0.99.3 milestone Mar 31, 2020
@anuraaga
Copy link
Collaborator Author

Ah was because of the early return for past deadline. Seems complicated to special case it in all the other methods too so just removed the optimization.

minwoox
minwoox approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

ikhoon
ikhoon approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @anuraaga

trustin
trustin approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@trustin trustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @anuraaga !

@trustin trustin merged commit 70ed3f5 into line:master Apr 2, 2020
gary-lo pushed a commit to airtasker/armeria that referenced this pull request Apr 16, 2020
@anuraaga @gary-lo
Compute grpc-timeout header after processing grpc deadline (line#2643)
3a8565e 
... instead of before.
fmguerreiro pushed a commit to fmguerreiro/armeria that referenced this pull request Sep 19, 2020
@anuraaga
Compute grpc-timeout header after processing grpc deadline (line#2643)
ac2445c 
... instead of before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trustin trustin trustin approved these changes

@ikhoon ikhoon ikhoon approved these changes

@minwoox minwoox minwoox approved these changes

Assignees
No one assigned
Labels
defect
Projects
None yet
Milestone
0.99.3
Development

Successfully merging this pull request may close these issues.
4 participants
@anuraaga @minwoox @trustin @ikhoon