Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Curator Service Discovery and Spring Cloud ZooKeeper #2749

Merged
merged 16 commits into from Jun 3, 2020
Merged

Support Curator Service Discovery and Spring Cloud ZooKeeper #2749

merged 16 commits into from Jun 3, 2020

Commits on May 29, 2020

  1. Support Curator-X-Discovery and Spring Cloud ZooKeeper 

    Motivation:
Related line#2673.
It will be nice if we support Curator-X-Discovery and Spring Cloud Zookeeper.

Modifications:
- Add `InstanceSpec` and `DiscoverySpec` to specify whether use default format or Curator compatible format.
- (Breaking)
  - `NodeValueCodec` is gone.
    - You now have to use `InstanceSpec` and `DiscoverySpec` to encode and decode.
    - `ZooKeeperEndpointGroupBuilder.codec(...)` and `ZooKeeperUpatingListenerBuilder.codec(...)` are gone as well.

Result:
- You can now use Armeria client and server with Curator-X-Discovery.
    @minwoox
    minwoox committed May 29, 2020
    Copy the full SHA
    f8320de View commit details
    Browse the repository at this point in the history

  2. Add tests

    @minwoox
    minwoox committed May 29, 2020
    Copy the full SHA
    457f591 View commit details
    Browse the repository at this point in the history

  3. Remove ZookeeperInstance

    @minwoox
    minwoox committed May 29, 2020
    Copy the full SHA
    65be57e View commit details
    Browse the repository at this point in the history

  4. Address comments by @trustin

    @minwoox
    minwoox committed May 29, 2020
    Copy the full SHA
    86424e5 View commit details
    Browse the repository at this point in the history

  5. Rename

    @minwoox
    minwoox committed May 29, 2020
    Copy the full SHA
    fc322c5 View commit details
    Browse the repository at this point in the history

  6. Fix test

    @minwoox
    minwoox committed May 29, 2020
    Copy the full SHA
    0f71d5c View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2020

  1. Rename classes and methods

    @minwoox
    minwoox committed Jun 1, 2020
    Copy the full SHA
    fd01c88 View commit details
    Browse the repository at this point in the history

  2. Address comments by @trustin

    @minwoox
    minwoox committed Jun 1, 2020
    Copy the full SHA
    e37127a View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2020

  1. Merge branch 'master' into x_discovery

    @minwoox
    minwoox committed Jun 2, 2020
    Copy the full SHA
    f535605 View commit details
    Browse the repository at this point in the history

  2. Fix

    @minwoox
    minwoox committed Jun 2, 2020
    Copy the full SHA
    b5cc191 View commit details
    Browse the repository at this point in the history

  3. Vaildate node path

    @minwoox
    minwoox committed Jun 2, 2020
    Copy the full SHA
    20b7e13 View commit details
    Browse the repository at this point in the history

  4. Use IllegalArgumentException

    @minwoox
    minwoox committed Jun 2, 2020
    Copy the full SHA
    f45e0a1 View commit details
    Browse the repository at this point in the history

  5. fix comment

    @minwoox
    minwoox committed Jun 2, 2020
    Copy the full SHA
    48ad9ae View commit details
    Browse the repository at this point in the history

  6. Fix exception messages

    @minwoox
    minwoox committed Jun 2, 2020
    Copy the full SHA
    4cb6e21 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2020

  1. Address comments by @ikhoon

    @minwoox
    minwoox committed Jun 3, 2020
    Copy the full SHA
    7629bf3 View commit details
    Browse the repository at this point in the history

  2. Fix

    @minwoox
    minwoox committed Jun 3, 2020
    Copy the full SHA
    e06daaf View commit details
    Browse the repository at this point in the history