Add shortcut methods that create event loops and blocking task executor thread pool #3602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3602 +/- ##
============================================
+ Coverage 73.00% 73.80% +0.79%
- Complexity 10880 14387 +3507
============================================
Files 947 1263 +316
Lines 41936 54938 +13002
Branches 5207 7026 +1819
============================================
+ Hits 30616 40546 +9930
- Misses 8662 10804 +2142
- Partials 2658 3588 +930
Continue to review full report at Codecov.
|
trustin
reviewed
Jun 5, 2021
Comment on lines
136
to
138
| * Sets the worker {@link EventLoopGroup} which is responsible for performing socket I/O and running | ||
| * {@link Client#execute(ClientRequestContext, Request)}. | ||
| * If not set, {@linkplain CommonPools#workerGroup() the common worker group} is used. |
There was a problem hiding this comment.
How about this:
Uses a newly created {@link EventLoopGroup} with the specified number of threads for
performing socket I/O and running ...
If not set... could be removed.
Comment on lines
422
to
426
| * Sets the worker {@link EventLoopGroup} which is responsible for performing socket I/O and running | ||
| * {@link Service#serve(ServiceRequestContext, Request)}. | ||
| * If not set, {@linkplain CommonPools#workerGroup() the common worker group} is used. | ||
| * The worker {@link EventLoopGroup} will be shut down when the {@link Server} stops. |
| @@ -94,7 +93,7 @@ | |||
| @BeforeAll | |||
| static void beforeAll() { | |||
| // use different eventLoop from server's so that clients don't hang when the eventLoop in server hangs | |||
| clientFactory = ClientFactory.builder().workerGroup(EventLoopGroups.newEventLoopGroup(2), true).build(); | |||
| clientFactory = ClientFactory.builder().workerGroup(2).build(); | |||
trustin
approved these changes
Jun 5, 2021
|
@minwoox Gentle ping |
|
@kezhenxu94 I've just realized you didn't add |
Added |
ikhoon
approved these changes
Jun 15, 2021
core/src/main/java/com/linecorp/armeria/server/ServerBuilder.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Ikhun Um <ih.pert@gmail.com>
|
Please squash when merging 🙇 |
heowc
pushed a commit
to heowc/armeria
that referenced
this pull request
Jun 24, 2021
…or thread pool (line#3602) Motivation: It may be useful if a user can create a new event loop or blocking task executor that has the same life cycle with a `ClientFactory` or `Server`: ```java ClientFactory .builder() .workerGroup(3) .build() Server .builder() .workerGroup(3) .blockingTaskExecutor(10) ... .build() ``` Modifications: - Added `ClientFactoryBuilder.workerGroup(int)` - Added `ServerBuilder.workerGroup(int)` - Added `ServerBuilder.blockingTaskExecutor(int)` Result: - Closes line#3597
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It may be useful if a user can create a new event loop or blocking task executor that has the same life cycle with a
ClientFactoryorServer:Modifications:
ClientFactoryBuilder.workerGroup(int)ServerBuilder.workerGroup(int)ServerBuilder.blockingTaskExecutor(int)Result: