Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the shortcut methods that creates event loops and blocking task executor thread pool #3597

Closed
trustin opened this issue Jun 3, 2021 · 0 comments · Fixed by #3602
Closed

Add the shortcut methods that creates event loops and blocking task executor thread pool #3597

trustin opened this issue Jun 3, 2021 · 0 comments · Fixed by #3602
Labels
good first issue new feature
Milestone
1.9.0

Comments

@trustin
Copy link
Member

trustin commented Jun 3, 2021

It may be useful if a user can create a new event loop or blocking task executor that has the same life cycle with a ClientFactory or Server:

ClientFactory
  .builder()
  .workerGroup(3)
  .build()

Server
  .builder()
  .workerGroup(3)
  ...
  .build()
@trustin trustin added this to the 1.9.0 milestone Jun 3, 2021
@kezhenxu94 kezhenxu94 mentioned this issue Jun 3, 2021
Merged
trustin pushed a commit that referenced this issue Jun 21, 2021
@kezhenxu94
Add shortcut methods that create event loops and blocking task execut…
0fbd1cc 
…or thread pool (#3602)

Motivation:

It may be useful if a user can create a new event loop or blocking task executor that has the same life cycle with a `ClientFactory` or `Server`:

```java
ClientFactory
  .builder()
  .workerGroup(3)
  .build()

Server
  .builder()
  .workerGroup(3)
  .blockingTaskExecutor(10)
  ...
  .build()
```

Modifications:

- Added `ClientFactoryBuilder.workerGroup(int)`
- Added `ServerBuilder.workerGroup(int)`
- Added `ServerBuilder.blockingTaskExecutor(int)`

Result:

- Closes #3597
heowc pushed a commit to heowc/armeria that referenced this issue Jun 24, 2021
@kezhenxu94 @heowc
Add shortcut methods that create event loops and blocking task execut…
fd4542b 
…or thread pool (line#3602)

Motivation:

It may be useful if a user can create a new event loop or blocking task executor that has the same life cycle with a `ClientFactory` or `Server`:

```java
ClientFactory
  .builder()
  .workerGroup(3)
  .build()

Server
  .builder()
  .workerGroup(3)
  .blockingTaskExecutor(10)
  ...
  .build()
```

Modifications:

- Added `ClientFactoryBuilder.workerGroup(int)`
- Added `ServerBuilder.workerGroup(int)`
- Added `ServerBuilder.blockingTaskExecutor(int)`

Result:

- Closes line#3597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue new feature
Projects
None yet
Milestone
1.9.0
Development

Successfully merging a pull request may close this issue.

Add shortcut methods that create event loops and blocking task executor thread pool kzx94/armeria
1 participant
@trustin