Use jetty-alpn-agent to simplify pom.xml #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGreatTM |
trustin
force-pushed
the
use_jetty-alpn-agent
branch
from
b0887ad
to
2d314d3
Compare
Motivation: We had to add a new profile for each OpenJDK/OracleJDK release to make Maven choose the correct alpn-boot.jar and npn-boot.jar. As a result, our pom.xml has a large number of `<profile/>` sections. Modifications: - Use jetty-alpn-agent, which chooses the correct alpn-boot.jar and npn-boot.jar automatically to remove all the nasty profile sections from pom.xml - Visit https://github.com/trustin/jetty-alpn-agent for more info Result: Cleaner pom.xml
|
Cool! LGTM!! 👍 |
anuraaga
added a commit
that referenced
this pull request
Jan 5, 2016
Use jetty-alpn-agent to simplify pom.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We had to add a new profile for each OpenJDK/OracleJDK release to make
Maven choose the correct alpn-boot.jar and npn-boot.jar. As a result,
our pom.xml has a large number of
<profile/>sections.Modifications:
npn-boot.jar automatically to remove all the nasty profile sections
from pom.xml
Result:
Cleaner pom.xml