Replace commons-daemon and jsvc with something else. #277
Assignees
Labels
Comments
trustin
changed the title
hyangtack
added a commit
to hyangtack/centraldogma
that referenced
this issue
Feb 28, 2019
Motivation:
The current version of `jsvc` does not support Java 9+.
If we can remove `commons-daemon` from dependencies, we would have less blocker for supporting latest Java version.
Modifications:
- Removed `commons-daemon` from dependencies.
- Removed `jsvc` binaries from `dist/src/bin`.
- The server now creates a pidfile when it starts up and deletes it when it is terminated.
- `startup`/`shutdown` waits until the pidfile is created/deleted.
- Updated `Dockerfile`:
- Using `openjdk:lastest` instead of `openjdk:8`.
- Set the entry point in order to correctly handle a signal from a user.
`docker stop` command, which sends `TERM` signal to the container, will work.
Result:
- Less dependencies.
- Support Java 9+.
- Closes line#277
trustin
pushed a commit
that referenced
this issue
Mar 4, 2019
Motivation:
The current version of `jsvc` does not support Java 9+.
If we can remove `commons-daemon` from dependencies, we would have less blocker for supporting latest Java version.
Modifications:
- Removed `commons-daemon` from dependencies.
- Removed `jsvc` binaries from `dist/src/bin`.
- The server now creates a pidfile when it starts up and deletes it when it is terminated.
- `startup`/`shutdown` waits until the pidfile is created/deleted.
- Updated `Dockerfile`:
- Using `openjdk:lastest` instead of `openjdk:8`.
- Set the entry point in order to correctly handle a signal from a user.
`docker stop` command, which sends `TERM` signal to the container, will work.
Result:
- Less dependencies.
- Support Java 9+.
- Closes #277
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current version of jsvc does not support Java 9+
The text was updated successfully, but these errors were encountered: