Remove commons-daemon from dependencies #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
The current version of `jsvc` does not support Java 9+.
If we can remove `commons-daemon` from dependencies, we would have less blocker for supporting latest Java version.
Modifications:
- Removed `commons-daemon` from dependencies.
- Removed `jsvc` binaries from `dist/src/bin`.
- The server now creates a pidfile when it starts up and deletes it when it is terminated.
- `startup`/`shutdown` waits until the pidfile is created/deleted.
- Updated `Dockerfile`:
- Using `openjdk:lastest` instead of `openjdk:8`.
- Set the entry point in order to correctly handle a signal from a user.
`docker stop` command, which sends `TERM` signal to the container, will work.
Result:
- Less dependencies.
- Support Java 9+.
- Closes line#277
hyangtack
force-pushed
the
feature/remove_commons_daemon
branch
from
ddaeae3
to
cd16218
Compare
trustin
requested changes
Feb 28, 2019
server/src/main/java/com/linecorp/centraldogma/server/Main.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
============================================
- Coverage 66% 65.85% -0.16%
+ Complexity 2644 2642 -2
============================================
Files 306 306
Lines 11047 11063 +16
Branches 1211 1214 +3
============================================
- Hits 7292 7285 -7
- Misses 3055 3077 +22
- Partials 700 701 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
===========================================
- Coverage 66% 65.9% -0.11%
- Complexity 2644 2646 +2
===========================================
Files 306 306
Lines 11047 11062 +15
Branches 1211 1214 +3
===========================================
- Hits 7292 7290 -2
- Misses 3055 3074 +19
+ Partials 700 698 -2
Continue to review full report at Codecov.
|
trustin
approved these changes
Feb 28, 2019
server/src/main/java/com/linecorp/centraldogma/server/Main.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/linecorp/centraldogma/server/Main.java
Outdated
Show resolved
Hide resolved
hyangtack
added a commit
to hyangtack/centraldogma
that referenced
this pull request
Mar 5, 2019
Motivation: A user could configure the title of web-based administrative console by line#348. But it is only available to add some text to the end of pre-defined title which is `Central Dogma at ..hostname..`. We think it would be more useful if a user can customize the entire title of the web console. Modifications: - Made the entire title of the web console customizable. - A user can use ``{{hostname}}`` as a variable of the actual hostname that the server is running on. - Updated site document. - Misc - Try to move pidfile again silently when it caught `AtomicMoveNotSupportedException`. Result: - Closes line#43 - Usability.
trustin
pushed a commit
that referenced
this pull request
Mar 6, 2019
Motivation: A user could configure the title of web-based administrative console by #348. But it is only available to add some text to the end of pre-defined title which is `Central Dogma at ..hostname..`. We think it would be more useful if a user can customize the entire title of the web console. Modifications: - Made the entire title of the web console customizable. - A user can use ``{{hostname}}`` as a variable of the actual hostname that the server is running on. - Updated site document. - Misc - Try to move pidfile again silently when it caught `AtomicMoveNotSupportedException`. Result: - Closes #43 - Usability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The current version of
jsvcdoes not support Java 9+.If we can remove
commons-daemonfrom dependencies, we would have less blocker for supporting latest Java version.Modifications:
commons-daemonfrom dependencies.jsvcbinaries fromdist/src/bin.startup/shutdownwaits until the pidfile is created/deleted.Dockerfile:openjdk:lastestinstead ofopenjdk:8.docker stopcommand, which sendsTERMsignal to the container, will work.Result: