Fix a bug where GitRepository.compareTrees() operation is not cached.
#382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Even if we enabled cache, `null` can be set to `GitRepository.cache` depending on how a `GitRepository` was initialized. If it was newly created, cache will be set properly. Otherwise, it won't be. Modifications: - Removed the `childArgs` from `DirectoryBasedStorageManager` and made its subtypes call `init()` method explicitly, so that it is less error-prone. - Added a test case that makes sure `GitRepository.cache` is non-null for both code path. Result: - `GitRepository.compareTrees()` operation is cached properly.
trustin
force-pushed
the
fix_missing_cache
branch
from
09422df
to
c068582
Compare
Codecov Report
@@ Coverage Diff @@
## master #382 +/- ##
============================================
- Coverage 67.08% 66.99% -0.09%
+ Complexity 2851 2848 -3
============================================
Files 315 315
Lines 11902 11903 +1
Branches 1280 1282 +2
============================================
- Hits 7984 7975 -9
- Misses 3151 3158 +7
- Partials 767 770 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #382 +/- ##
============================================
- Coverage 67.08% 67.03% -0.05%
+ Complexity 2851 2850 -1
============================================
Files 315 315
Lines 11902 11903 +1
Branches 1280 1280
============================================
- Hits 7984 7979 -5
- Misses 3151 3160 +9
+ Partials 767 764 -3
Continue to review full report at Codecov.
|
minwoox
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Even if we enabled cache,
nullcan be set toGitRepository.cachedepending on how a
GitRepositorywas initialized. If it was newlycreated, cache will be set properly. Otherwise, it won't be.
Modifications:
childArgsfromDirectoryBasedStorageManagerand madeits subtypes call
init()method explicitly, so that it is lesserror-prone.
GitRepository.cacheis non-nullfor both code path.
Result:
GitRepository.compareTrees()operation is cached properly.