Add HTTP API version 1 #91

minwoox · 2017-11-17T01:31:52Z

Motivation:
The libthrift is not stable enough yet, we need two diffrent jars to compile.
If we use HTTP API, we can avoid that situation and have fewer depedencies for the client library.

Modifications:

Revise admin REST APIs
Add more APIs to cover all of the features in Thrift service

Result:

We are ready to transfer from Thrift to HTTP API

Todos:

Support adding and editing for multiple files
Support preview diffs
Adapt MetaDataService
Create URLs with URI template parser
Remove admin package or keep it minimum
Remove thrift service ultimately

minwoox · 2017-11-17T01:33:18Z

Please ignore the *Dtos for now. Since the fields for the response are not fixed, I just used POJO withe getters and setters without much thinking about it.
Also, please consider that exception handling will be modified using "@ExceptionHandler".
And admin package will be moved as well.

minwoox · 2017-11-17T06:27:42Z

server/src/main/java/com/linecorp/centraldogma/server/internal/httpapi/ContentServiceV1.java

+     * <p>Adds or edit a file.
+     */
+    @Put("regex:/projects/(?<projectName>[^/]+)/repos/(?<repoName>[^/]+)/contents(?<path>/.*$)")
+    public CompletionStage<EntryDto> addOrEditFile(


Because there's an input for revision, this is not idempotent. If I change this using POST, it does not make sense to edit file. Do you have an idea for this?
Or change the logic which returns just 200 OK when there's no change between the files and the head revision?

I think it's OK to use POST here. Why doesn't it make sense to use POST for editing a file? We could 'post' a file modification request and the server could process it immediately?

I have read the spec again, and it's fine using POST here. :-)

minwoox · 2017-11-17T06:28:11Z

.../main/java/com/linecorp/centraldogma/server/internal/httpapi/HttpApiV1ResponseConverter.java

+                ((ObjectNode) jsonNode).remove("url");
+                final HttpHeaders headers = HttpHeaders.of(HttpStatus.CREATED)
+                                                       .add(HttpHeaderNames.LOCATION, url)
+                                                       .addObject(HttpHeaderNames.CONTENT_TYPE,


Do we need convenience methods for this on upstream? like HttpResponse.of(HttpHeaders .....)?

HttpRequest seems to have one. It would be great to have something similar in HttpResponse as well. Please send a PR.

minwoox · 2017-11-17T06:30:06Z

server/src/main/java/com/linecorp/centraldogma/server/internal/httpapi/ContentServiceV1.java

+     *
+     * <p>Deletes a file.
+     */
+    @Delete("regex:/projects/(?<projectName>[^/]+)/repos/(?<repoName>[^/]+)/contents(?<path>/.*$)")


Do we need convenience methods for this on upstream? like HttpClient.delete(uri, string body)? It is not a usual case though.

Like adding Repository.deleteFiles(Revision revision, String pathPattern)? Sounds good to me.

codecov-io · 2017-11-17T06:38:45Z

Codecov Report

Merging #91 into master will increase coverage by 1.68%.
The diff coverage is 72.9%.

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   57.25%   58.94%   +1.68%     
==========================================
  Files         229      249      +20     
  Lines        7971     8498     +527     
  Branches      933      994      +61     
==========================================
+ Hits         4564     5009     +445     
- Misses       2830     2877      +47     
- Partials      577      612      +35

Impacted Files	Coverage Δ
...n/java/com/linecorp/centraldogma/common/Query.java	`37.5% <ø> (ø)`	⬆️
...ma/server/internal/admin/service/TokenService.java	`5.19% <ø> (+5.19%)`	⬆️
.../server/internal/admin/service/RepositoryUtil.java	`93.75% <ø> (ø)`	⬆️
...server/internal/admin/service/MetadataService.java	`68.5% <ø> (ø)`	⬆️
...ntraldogma/internal/api/v1/HttpApiV1Constants.java	`0% <0%> (ø)`
...ernal/admin/util/RestfulJsonResponseConverter.java	`0% <0%> (ø)`	⬆️
.../server/internal/admin/service/ProjectService.java	`0% <0%> (ø)`	⬆️
...gma/server/internal/admin/service/UserService.java	`0% <0%> (ø)`	⬆️
...rver/internal/admin/service/RepositoryService.java	`0% <0%> (ø)`	⬆️
...internal/storage/repository/git/GitRepository.java	`79.05% <100%> (-0.23%)`	⬇️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0e55a9...e024669. Read the comment docs.

trustin · 2017-11-21T06:24:22Z

common/src/main/java/com/linecorp/centraldogma/common/Markup.java

+     * Returns the {@link Markup} from the specified {@code value}. If none of markup is matched,
+     * this will return {@link #UNKNOWN}.
+     */
+    public static Markup getMarkup(@Nullable String value) {


parse or of ?

Fixed. Thank you~!

trustin · 2017-11-21T06:25:55Z

common/src/main/java/com/linecorp/centraldogma/internal/Jackson.java

+    }
+
+    public static ArrayNode createArrayNode() {
+        return compactMapper.createArrayNode();


You could just use JsonNodeFactory.instance.*Node()?

trustin · 2017-11-21T06:26:07Z

common/src/main/java/com/linecorp/centraldogma/internal/Jackson.java

@@ -165,6 +167,15 @@ public static String writeValueAsPrettyString(Object value) throws JsonProcessin
        return compactMapper.convertValue(fromValue, toValueTypeRef);
    }

+    public static ObjectNode createObjectNode() {
+        compactMapper.createArrayNode();
+        return compactMapper.createObjectNode();


You could just use JsonNodeFactory.instance.*Node()?

Fixed. Thank you~!

trustin · 2017-11-21T06:29:46Z

server/src/main/java/com/linecorp/centraldogma/server/internal/httpapi/ContentServiceV1.java

+
+    private void checkRepositoryExists(String projectName, String repoName) {
+        if (!projectManager().exists(projectName)) {
+            throw new HttpResponseException(HttpStatus.BAD_REQUEST);


NOT_FOUND?

Fixed. Thank you~!

trustin · 2017-11-21T06:29:51Z

server/src/main/java/com/linecorp/centraldogma/server/internal/httpapi/ContentServiceV1.java

+        }
+
+        if (!projectManager().get(projectName).repos().exists(repoName)) {
+            throw new HttpResponseException(HttpStatus.BAD_REQUEST);


NOT_FOUND?

trustin · 2017-11-21T06:36:30Z

server/src/main/java/com/linecorp/centraldogma/server/internal/httpapi/ContentServiceV1.java

+
+    private static Change<?> getChangeOfPatch(String path, JsonNode jsonNode) {
+        if (path.charAt(path.length() - 1) == '/') {
+            throw new HttpResponseException(HttpStatus.BAD_REQUEST);


Perhaps we could rely on Util.validateFilePath() where necessary?

Fixed. Thank you~!

trustin · 2017-11-21T06:38:22Z

.../main/java/com/linecorp/centraldogma/server/internal/httpapi/HttpApiV1ResponseConverter.java

+                ((ObjectNode) jsonNode).remove("url");
+                final HttpHeaders headers = HttpHeaders.of(HttpStatus.CREATED)
+                                                       .add(HttpHeaderNames.LOCATION, url)
+                                                       .addObject(HttpHeaderNames.CONTENT_TYPE,


HttpRequest seems to have one. It would be great to have something similar in HttpResponse as well. Please send a PR.

trustin · 2017-11-21T06:43:10Z

server/src/main/java/com/linecorp/centraldogma/server/internal/httpapi/RepositoryServiceV1.java

+                                                      @Param("repoName") String repoName) {
+        checkProjectExists(projectName);
+        final long removeTimeMillis = System.currentTimeMillis();
+        return execute(Command.removeRepository(removeTimeMillis, AuthenticationUtil.currentAuthor(),


You can just use the factory method without timestamp parameter to let the upstream decide.

trustin · 2017-11-21T06:43:56Z

server/src/main/java/com/linecorp/centraldogma/server/internal/httpapi/RepositoryServiceV1.java

+        final String repoName = jsonNode.asText();
+        checkArgument(!isNullOrEmpty(repoName), "repository name should be non-null");
+
+        return execute(Command.createRepository(System.currentTimeMillis(), AuthenticationUtil.currentAuthor(),


You can just use the factory method without timestamp parameter to let the upstream decide.

trustin · 2017-11-21T06:44:48Z

server/src/main/java/com/linecorp/centraldogma/server/internal/httpapi/RepositoryServiceV1.java

+            throw new HttpResponseException(HttpStatus.BAD_REQUEST);
+        }
+
+        return execute(Command.unremoveRepository(System.currentTimeMillis(),


You can just use the factory method without timestamp parameter to let the upstream decide.

I was planning to use the value to return the client at first. I will remove them for now, and bring it back if it needs. :-)

hyangtack · 2017-11-27T06:19:10Z

server/src/main/java/com/linecorp/centraldogma/server/internal/httpapi/ContentServiceV1.java

+    }
+
+    /**
+     * POST /projects/{projectName}/repos/{repoName}/contents{path}?revision={revision}


Looks different from the implementation. Which one is correct?

I didn't change the path when it's changed from PUT to POST, thank you~!

hyangtack · 2017-11-27T06:20:01Z

server/src/main/java/com/linecorp/centraldogma/server/internal/httpapi/ContentServiceV1.java

+    }
+
+    /**
+     * GET /projects/{projectName}/repos/{repoName}/contents{path}?revision={revision}


revision={revision} -> revision={revision}&?

Motivation: The libthrift is not stable enough yet, we need two diffrent jars to compile. If we use HTTP API, we can avoid that situation and have fewer depedencies for the client library. Modifications: - Revise admin REST APIs - Add more APIs to cover all of the features in Thrift service Result: - We are ready to transfer from Thrift to HTTP API Todos: - Support adding and editing for multiple files - Support preview diffs - Create URLs with URI template parser - Remove admin package or keep it minumun - Remove thrift service ultimately

hyangtack · 2017-12-15T02:10:47Z

server/src/main/java/com/linecorp/centraldogma/server/internal/httpapi/ContentServiceV1.java

+     * <p>Adds or edits a file.
+     */
+    @Post("/projects/{projectName}/repos/{repoName}/contents")
+    public CompletionStage<EntryDto> addOrEditFile(@Param("projectName") String projectName,


nit: EntryDto -> EntryDto<?>?

hyangtack · 2017-12-15T02:17:30Z

server/src/main/java/com/linecorp/centraldogma/server/internal/httpapi/WatchService.java

+     */
+    public CompletableFuture<Revision> watchRepository(Repository repo, Revision lastKnownRevision,
+                                                       String pathPattern, long timeoutMillis) {
+        if (isServerStopping()) {


Just curious. Is this kind of prevention required for every API calls? I mean that do we have something like a decorator which sends a failure response when the server starts stopping?

Just curious. Is this kind of prevention required for every API calls? I mean that do we have something like a decorator which sends a failure response when the server starts stopping?

Sounds like a good idea which is worth its own issue. Could you create one?

Created! #107

Thanks, @hyangtack !

hyangtack · 2017-12-15T03:27:41Z

server/src/main/java/com/linecorp/centraldogma/server/internal/httpapi/CommitServiceV1.java

+        return projectManager().get(projectName).repos().get(repoName);
+    }
+
+    private void checkRepositoryExists(String projectName, String repoName) {


How about returning Repository here so that we can call this once to validate the name and get Repository instead of calling getRepository again?

Or, we may move this kind of codes to a request converter later.

hyangtack · 2017-12-15T04:41:29Z

server/src/main/java/com/linecorp/centraldogma/server/internal/httpapi/ContentServiceV1.java

+                                                   AggregatedHttpMessage message) {
+        checkRepositoryExists(projectName, repoName);
+
+        final Entry<CommitMessageDto, Change<?>> commitMessageAndChange = commitMessageAndChange(message);


Try to use a request converter later! :-)

hyangtack · 2017-12-15T04:51:37Z

server/src/main/java/com/linecorp/centraldogma/server/internal/httpapi/ContentServiceV1.java

+                                       @Param("revision") @Default("-1") String revision,
+                                       @Param("queryType") Optional<String> queryType,
+                                       @Param("expression") Optional<String> expression,
+                                       @Header("if-none-match") Optional<String> ifNoneMatch,


Try to use a request converter here, too. :-) I think it'd be better to make an object like WatchRequest so that we can move the codes like parsing timeout to the request converter.

I realized that we need to make RequestObject as optional for this. I'm not sure if it's good idea though. WDYT @hyangtack ?

I think we can return Optional<?> from a request converter. Not possible?

hyangtack · 2017-12-15T09:28:44Z

...rc/main/java/com/linecorp/centraldogma/internal/httpapi/v1/CommitMessageDtoDeserializer.java

+        final JsonNode jsonNode = p.readValueAsTree();
+        final JsonNode summary = jsonNode.get("summary");
+        if (summary.textValue() == null) {
+            ctxt.reportInputMismatch(CommitMessageDto.class, "commit message should hava summary");


nit: hava -> have

hyangtack · 2017-12-15T09:39:57Z

common/src/main/java/com/linecorp/centraldogma/internal/httpapi/v1/EntryDto.java

+        this.type = requireNonNull(type, "type");
+        this.content = null;
+        this.revision = requireNonNull(revision, "revision");
+        url = PROJECTS_PREFIX + '/' + projectName + REPOS + '/' + repoName + path;


I think it'd be better to remove the logic which generates a URL from DTO class. :-)

trustin · 2017-12-15T03:13:53Z

common/src/main/java/com/linecorp/centraldogma/common/IdentityQuery.java

@@ -31,7 +32,8 @@

    @JsonCreator
    IdentityQuery(@JsonProperty("path") String path) {
-        this.path = requireNonNull(path, "path");
+        requireNonNull(path, "path");


requireNonNull is redundant because validateFilePath() does null check as well.

trustin · 2017-12-15T03:14:07Z

common/src/main/java/com/linecorp/centraldogma/common/JsonPathQuery.java

@@ -41,7 +42,7 @@
        requireNonNull(path, "path");


requireNonNull is redundant because validateJsonFilePath() does null check as well.

trustin · 2017-12-15T03:14:17Z

common/src/main/java/com/linecorp/centraldogma/common/JsonPathQuery.java

@@ -52,7 +53,7 @@
        requireNonNull(path, "path");


requireNonNull is redundant because validateJsonFilePath() does null check as well.

trustin · 2017-12-15T03:16:33Z

common/src/main/java/com/linecorp/centraldogma/internal/Util.java

@@ -38,6 +38,8 @@
            "^(?:[-_0-9a-zA-Z](?:[-_\\.0-9a-zA-Z]*[-_0-9a-zA-Z])?)+$");
    private static final Pattern FILE_PATH_PATTERN = Pattern.compile(
            "^(?:/[-_0-9a-zA-Z](?:[-_\\.0-9a-zA-Z]*[-_0-9a-zA-Z])?)+$");
+    private static final Pattern JSON_FILE_PATH_PATTERN = Pattern.compile(
+            "^(?:/[-_0-9a-zA-Z](?:[-_\\.0-9a-zA-Z]*[-_0-9a-zA-Z])?)+\\.(?i)json$");


Do we treat .JSON as JSON? IIRC we only accept .json, but my memory may not be correct.

I did not know. That was just my decision. I will remove the (?i) :-)

Actually, it seems case-insensitive. In EntryType:

/** * Guesses the {@link EntryType} from the specified {@code path}. */ public static EntryType guessFromPath(String path) { requireNonNull(path, "path"); if (path.isEmpty()) { throw new IllegalArgumentException("empty path"); } if (path.charAt(path.length() - 1) == '/') { return DIRECTORY; } if (Ascii.toLowerCase(path).endsWith(".json")) { return JSON; } return TEXT; }

Sorry!

trustin · 2017-12-15T03:18:05Z

common/src/main/java/com/linecorp/centraldogma/internal/Util.java

+        return isValidDirPath(path, false);
+    }
+
+    public static boolean isValidDirPath(String path, boolean mustEndsWithSlash) {


mustEnds -> mustEnd

trustin · 2017-12-15T09:44:13Z

server/src/main/java/com/linecorp/centraldogma/server/internal/httpapi/ProjectServiceV1.java

+                    if (thrown != null) {
+                        if (Throwables.getRootCause(thrown) instanceof StorageExistsException) {
+                            throw newHttpResponseException(HttpStatus.BAD_REQUEST,
+                                                           "project " + name + " already exists");


Perhaps CONFLICT?

trustin · 2017-12-15T09:45:07Z

server/src/main/java/com/linecorp/centraldogma/server/internal/httpapi/ProjectServiceV1.java

+        if (!jsonNode.equals(unremovePatch)) {
+            throw newHttpResponseException(HttpStatus.BAD_REQUEST,
+                                           "not supported JSON patch: " + message.content() +
+                                           " (expected: " + unremovePatch.toString() + ')');


Maybe CONFLICT?

Is this CONFLICT? This patch method only supports unremovePatch for now, so if the request is sent except the patch, I thought we need to give back BAD_REQUEST.

I think there are two cases involved here.

The JSON document is a JSON patch but is not equal to unremovePatch, which would be CONFLICT.

The JSON document is not a JSON patch, which would be BAD_REQUEST.

Could we send BAD_REQUEST when it's not a JSON patch or CONFLICT otherwise? You could try to deserialize the content into JsonPatch to test if it's a JSON patch.

trustin · 2017-12-15T09:45:45Z

server/src/main/java/com/linecorp/centraldogma/server/internal/httpapi/RepositoryServiceV1.java

+                    if (thrown != null) {
+                        if (Throwables.getRootCause(thrown) instanceof StorageExistsException) {
+                            throw newHttpResponseException(HttpStatus.BAD_REQUEST,
+                                                           "repository " + repoName + " already exists");


CONFLICT?

trustin · 2017-12-15T09:46:07Z

server/src/main/java/com/linecorp/centraldogma/server/internal/httpapi/RepositoryServiceV1.java

+        if (!unremovePatch.equals(jsonNode)) {
+            throw newHttpResponseException(HttpStatus.BAD_REQUEST,
+                                           "not supported JSON patch: " + message.content() +
+                                           " (expected: " + unremovePatch.toString() + ')');


CONFLICT?

trustin · 2017-12-15T09:47:03Z

server/src/main/java/com/linecorp/centraldogma/server/internal/httpapi/WatchService.java

+     */
+    public CompletableFuture<Revision> watchRepository(Repository repo, Revision lastKnownRevision,
+                                                       String pathPattern, long timeoutMillis) {
+        if (isServerStopping()) {


Just curious. Is this kind of prevention required for every API calls? I mean that do we have something like a decorator which sends a failure response when the server starts stopping?

Sounds like a good idea which is worth its own issue. Could you create one?

hyangtack · 2017-12-20T05:25:37Z

common/src/main/java/com/linecorp/centraldogma/internal/httpapi/v1/ChangeDto.java

+
+import com.linecorp.centraldogma.common.ChangeType;
+
+@JsonInclude(Include.NON_DEFAULT)


Is this intentional? @JsonInclude(Include.NON_NULL)?

Yeah~ the content can be null. I just wanted the client gets only path and type when the content is null. :-)

trustin

Left some nits

trustin · 2017-12-20T05:25:29Z

common/src/main/java/com/linecorp/centraldogma/common/QueryType.java

+            return IDENTITY;
+        }
+
+        final String queryType = Ascii.toUpperCase(value);


Seems like uppercasing here is unnecessary because you used equalsIgnoreCase?

trustin · 2017-12-20T05:26:01Z

common/src/main/java/com/linecorp/centraldogma/common/QueryType.java

+            return JSON_PATH;
+        }
+
+        return IDENTITY;


Shouldn't we raise an exception or return null?

trustin · 2017-12-20T05:34:26Z

server/src/main/java/com/linecorp/centraldogma/server/CentralDogma.java

+
+            @Override
+            public String meterTag() {
+                return "hostnameService";


Just hostname?

trustin · 2017-12-20T05:52:22Z

server/src/main/java/com/linecorp/centraldogma/server/internal/httpapi/WatchService.java

+/**
+ * A service class for watching repository or a file.
+ */
+public class WatchService {


nit: Probably OK to make *Service classes final?

trustin · 2017-12-20T08:02:53Z

Thank you, @minwoox !

minwoox requested review from trustin and hyangtack November 17, 2017 01:32

minwoox force-pushed the http_api_v1 branch 3 times, most recently from babd684 to d26fd79 Compare November 17, 2017 06:29

minwoox commented Nov 17, 2017

View reviewed changes

minwoox force-pushed the http_api_v1 branch from d26fd79 to 8834e7f Compare November 17, 2017 06:40

trustin reviewed Nov 21, 2017

View reviewed changes

minwoox force-pushed the http_api_v1 branch 4 times, most recently from 6776c93 to 4a47f24 Compare November 24, 2017 10:25

hyangtack reviewed Nov 27, 2017

View reviewed changes

minwoox force-pushed the http_api_v1 branch 4 times, most recently from fbb8090 to 6130fa9 Compare December 14, 2017 09:00

minwoox force-pushed the http_api_v1 branch from 6130fa9 to bb69c95 Compare December 14, 2017 09:33

minwoox changed the title ~~[WIP] Add HTTP API version 1~~ Add HTTP API version 1 Dec 14, 2017

minwoox force-pushed the http_api_v1 branch 2 times, most recently from 2542bc4 to 0f8bc09 Compare December 14, 2017 12:36

Response with HttpStatus.CONFLICT when changeConflict

bf45eb7

minwoox force-pushed the http_api_v1 branch from 0f8bc09 to bf45eb7 Compare December 15, 2017 01:36

hyangtack reviewed Dec 15, 2017

View reviewed changes

trustin requested changes Dec 15, 2017

View reviewed changes

hyangtack mentioned this pull request Dec 18, 2017

Make the server send a failure response after it starts to be stopped #107

Open

minwoox force-pushed the http_api_v1 branch 5 times, most recently from d235066 to 75b565b Compare December 20, 2017 03:20

Apply RequestConverter

f4dad9b

minwoox force-pushed the http_api_v1 branch from 75b565b to f4dad9b Compare December 20, 2017 05:14

hyangtack reviewed Dec 20, 2017

View reviewed changes

trustin reviewed Dec 20, 2017

View reviewed changes

address comments

94fdbe9

minwoox force-pushed the http_api_v1 branch from aec31ea to 94fdbe9 Compare December 20, 2017 06:36

hyangtack approved these changes Dec 20, 2017

View reviewed changes

Remove unnecessary http query

bfd6fab

trustin approved these changes Dec 20, 2017

View reviewed changes

trustin added the new feature label Dec 20, 2017

trustin added this to the 0.20.0 milestone Dec 20, 2017

Change package name

e024669

trustin merged commit e9fb9f7 into line:master Dec 20, 2017

minwoox deleted the http_api_v1 branch December 20, 2017 08:12

minwoox mentioned this pull request Aug 16, 2022

Revise RESTful API and implementation #64

Closed


		import com.linecorp.centraldogma.common.ChangeType;

		@JsonInclude(Include.NON_DEFAULT)

Add HTTP API version 1 #91

Add HTTP API version 1 #91

Conversation

minwoox commented Nov 17, 2017 • edited Loading

minwoox commented Nov 17, 2017 • edited Loading

minwoox Nov 17, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Nov 17, 2017 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

trustin Dec 18, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

trustin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

trustin commented Dec 20, 2017

minwoox commented Nov 17, 2017 •

edited

Loading

minwoox commented Nov 17, 2017 •

edited

Loading

minwoox Nov 17, 2017 •

edited

Loading

codecov-io commented Nov 17, 2017 •

edited

Loading

trustin Dec 18, 2017 •

edited

Loading